Skip to content

Conversation

@mxsoco
Copy link
Collaborator

@mxsoco mxsoco commented Dec 13, 2024

No description provided.

@mxsoco mxsoco self-assigned this Dec 13, 2024
@netlify
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for abgov-ui-component-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d4f309f
🔍 Latest deploy log https://app.netlify.com/sites/abgov-ui-component-docs/deploys/67645fe0b31c3b0008f51c70
😎 Deploy Preview https://deploy-preview-284--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 0
Accessibility: 100
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@mxsoco mxsoco marked this pull request as draft December 13, 2024 23:21
@ArakTaiRoth
Copy link
Collaborator

ArakTaiRoth commented Dec 18, 2024

I believe both examples should be centred

@ArakTaiRoth
Copy link
Collaborator

ArakTaiRoth commented Dec 18, 2024

Issues with code:

  • The label for form item is wrong in Angular under Event based
  • missing type="tertiary" for goa-button in Angular under Event based and under Reactive forms
  • The label for form item is wrong in Angular under Reactive forms
  • helptext doesn't need to be defined in Angular under Reactive forms
  • 'mb' shouldn't be defined for form item in Angular under Reactive forms
  • Can remove the console.log in Angular under Reactive forms

@mxsoco mxsoco closed this by deleting the head repository May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants