fix(#2408): form stepper docs #362
Conversation
syedszeeshan
changed the title
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
syedszeeshan
changed the title
vanessatran-ddi
left a comment
vanessatran-ddi
left a comment
There was a problem hiding this comment.
On the 2nd example, you may want to change the note:
The status of each step can be configured to either “complete” or “incomplete” using the status property.
I think it makes sense to add not-started to this example too.
And also we need to update the package.json for the latest alpha version.
syedszeeshan
force-pushed
the
Syed/2408-Docs
branch
from
d546650 to
782db25
Compare
|
@vanessatran-ddi On hold....will resume once this PR GovAlta/ui-components#2702 gets merged to alpha |
syedszeeshan
force-pushed
the
Syed/2408-Docs
branch
from
782db25 to
2a56f2f
Compare
# Conflicts: # package-lock.json # package.json
| "incomplete" | ||
| "not-started" | ||
| ]) | ||
| function setPage(page: number) { |
There was a problem hiding this comment.
The function setPage here is different from the function setStatusPage at line 20. Therefore when I copy the code snippet of React (version 6), and play it, the step 4 is updated to be completed when I navigate to step 4 and navigate back to step 3, while on the sandbox it doesn't show that. (Step 4 remains not-started even we navigate to back and forth). I think we should update the code snippet to make it synced with the code we use inside the Example sandbox.
There was a problem hiding this comment.
The difference is:
setStatus((prevStatus) =>
prevStatus.map((_, index) => (index < page ? "complete" : "incomplete"))
);
while the setStatusStep line 20 doesn't have that
There was a problem hiding this comment.
PR has been updated.
Story: GovAlta/ui-components#2408
UI PR: GovAlta/ui-components#2702