-
Notifications
You must be signed in to change notification settings - Fork 10
feat(#2715): Add examples section that is integrated with Github #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
efd373c to
57337c2
Compare
57337c2 to
68ae5c6
Compare
|
@twjeffery @bdfranck I think one thing to look at when testing this, is load times. We might be able to add caching which would help significantly, but we'd need a way to verify when the cache needs to be updated. For now though, load times might be an issue. |
Good point Dustin. I created this sub-issue after some initial exploration: GovAlta/ui-components#2725 I don't think we should start this until we finalize the example pages and the graphQL needs so that we don't have to keep updating it. |
63aa41f to
67f990d
Compare
… thumbnail images
…p of content pages, added basic layout to Examples side menu,
bdfranck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the deploy preview...
- ✅ The example page loads with only three requests to GitHub's GraphQL server
- ✅ The GraphQL data is cached in the browser's localstorage
- ✅ The cached data has an expiry
- ✅ The expiry time is 24 hours in the future
- ✅ All the published examples have thumbnails
Looks good to me! 👍
A first spike on using our githhub backlog to populate the content on the component and examples page on the design system website.
I redid the AllComponents page using github to populate the content.
This should be visually and functionally the same as https://design.alberta.ca/components, but now all of the content is pulled from Design System