fix(#2714) - docs popover examples (button, link, iconbutton)#387
fix(#2714) - docs popover examples (button, link, iconbutton)#387
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
91a9534 to
3bbc0da
Compare
3bbc0da to
91ee308
Compare
|
QA feedback: When we switch to lts, we should have a banner below the example to let users know the reason why we don't see the code snippet Question: |
|
@vanessatran-ddi |
|
Hi @twjeffery Should we put the banner at the bottom of the page or under each example? |
vanessatran-ddi
left a comment
There was a problem hiding this comment.
It looks good for me. 2 questions pending waiting for @chrisolsen and @twjeffery to confirm. I approve first.
twjeffery
left a comment
There was a problem hiding this comment.
@syedszeeshan Looks good overall.
A few minor changes:
- Adjust the third example so that the icon button is in the top right
- Change wording of example names to:
- "Close a Popover with a Button"
- "Close a Popover with a Link"
- "Close a Popover with an Icon Button"
09fc872 to
0e2a748
Compare
|
@twjeffery |




Story: GovAlta/ui-components#2714