Skip to content

fix(#2714) - docs popover examples (button, link, iconbutton)#387

Merged
bdfranck merged 3 commits intoalphafrom
Syed/2714-docs
Jul 3, 2025
Merged

fix(#2714) - docs popover examples (button, link, iconbutton)#387
bdfranck merged 3 commits intoalphafrom
Syed/2714-docs

Conversation

@syedszeeshan
Copy link
Collaborator

@syedszeeshan syedszeeshan commented Jun 17, 2025

@netlify
Copy link

netlify bot commented Jun 17, 2025

Deploy Preview for abgov-ui-component-docs ready!

Name Link
🔨 Latest commit 0e2a748
🔍 Latest deploy log https://app.netlify.com/projects/abgov-ui-component-docs/deploys/685f03056c11880008d3278f
😎 Deploy Preview https://deploy-preview-387--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 0
Accessibility: 93
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@syedszeeshan syedszeeshan force-pushed the Syed/2714-docs branch 2 times, most recently from 91a9534 to 3bbc0da Compare June 17, 2025 22:58
@syedszeeshan syedszeeshan changed the title NOT READY - fix(#2714) - docs popover examples (button, link, iconbutton) fix(#2714) - docs popover examples (button, link, iconbutton) Jun 18, 2025
@syedszeeshan syedszeeshan marked this pull request as ready for review June 18, 2025 16:04
@ArakTaiRoth ArakTaiRoth linked an issue Jun 19, 2025 that may be closed by this pull request
@ArakTaiRoth ArakTaiRoth requested a review from twjeffery June 19, 2025 00:02
@vanessatran-ddi
Copy link
Collaborator

QA feedback:

When we switch to lts, we should have a banner below the example to let users know the reason why we don't see the code snippet
image
Example: Checkbox, 3rd example on https://design.alberta.ca/components/checkbox#reveal-input-based-on-selection, React lts version
image

Question:
Should we add action and actionArgs and actionArg to our GoabButton, GoabIconButton and GoabLink @chrisolsen ?
Do we need to documen an example how to use actionArgs?

@syedszeeshan
Copy link
Collaborator Author

@vanessatran-ddi
LTS info banner has been added and PR updated

@vanessatran-ddi
Copy link
Collaborator

Hi @twjeffery Should we put the banner at the bottom of the page or under each example?
image

Copy link
Collaborator

@vanessatran-ddi vanessatran-ddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for me. 2 questions pending waiting for @chrisolsen and @twjeffery to confirm. I approve first.

Copy link
Collaborator

@twjeffery twjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syedszeeshan Looks good overall.

A few minor changes:

  • Adjust the third example so that the icon button is in the top right
  • Change wording of example names to:
    • "Close a Popover with a Button"
    • "Close a Popover with a Link"
    • "Close a Popover with an Icon Button"

@syedszeeshan
Copy link
Collaborator Author

@twjeffery
PR has been updated as requested.

@bdfranck bdfranck merged commit 9463474 into alpha Jul 3, 2025
7 checks passed
@bdfranck bdfranck deleted the Syed/2714-docs branch July 3, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Popover documentation

4 participants