Skip to content

feat(#2850): add temporary notification#396

Merged
twjeffery merged 1 commit intoalphafrom
vanessa/2850-temporary-notification-docs
Jul 21, 2025
Merged

feat(#2850): add temporary notification#396
twjeffery merged 1 commit intoalphafrom
vanessa/2850-temporary-notification-docs

Conversation

@vanessatran-ddi
Copy link
Collaborator

No description provided.

@vanessatran-ddi vanessatran-ddi self-assigned this Jul 11, 2025
@netlify
Copy link

netlify bot commented Jul 11, 2025

Deploy Preview for abgov-ui-component-docs ready!

Name Link
🔨 Latest commit d1f7bf6
🔍 Latest deploy log https://app.netlify.com/projects/abgov-ui-component-docs/deploys/687ab97194c3f00008f4529f
😎 Deploy Preview https://deploy-preview-396--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 0
Accessibility: 93
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/2850-temporary-notification-docs branch from a072a28 to 14a4975 Compare July 11, 2025 16:26
@vanessatran-ddi
Copy link
Collaborator Author

Hi @twjeffery I addressed the first round of feedbacks:

  1. Fixed issue where setting duration to 0 didn't disable auto-dismiss: PR is on the ui-components fix(#2881): temporary notification set 0 to stop auto-dismiss ui-components#2882 (We can test it once we merge this PR to alpha)

  2. remove animation direction from sandbox controls and remove the helper text "Controller position" from both vertical and
    horizontal position fields

  3. Improved Action Button Behavior

  • Enhanced the action button functionality to immediately dismiss the current notification
    when clicked
  • Added logic to show "Action performed!" notification right after action click instead of
    waiting for timeout
  1. Changed "New" badge type from "important" to "success" (green color) for Drawer and Temporary Notification "New"

  2. Increased side menu width from 180px to 220px to prevent badge overlap with content. I also tested with polypane to make sure it works well

image

@ArakTaiRoth ArakTaiRoth linked an issue Jul 14, 2025 that may be closed by this pull request
@ArakTaiRoth ArakTaiRoth requested a review from bdfranck July 14, 2025 18:43
@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/2850-temporary-notification-docs branch 2 times, most recently from 9520dc9 to dbdab51 Compare July 16, 2025 00:17
@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/2850-temporary-notification-docs branch 3 times, most recently from e5776b2 to 19a87cd Compare July 16, 2025 21:38
@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/2850-temporary-notification-docs branch from 19a87cd to 9164873 Compare July 16, 2025 22:00
@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/2850-temporary-notification-docs branch from 6711e65 to f3bbb35 Compare July 17, 2025 00:18
@vanessatran-ddi
Copy link
Collaborator Author

Hi @twjeffery and @chrisolsen I addressed all comments. Please let me know if there are anything else.

@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/2850-temporary-notification-docs branch 3 times, most recently from 4020da5 to 54d3615 Compare July 17, 2025 20:33
@vanessatran-ddi
Copy link
Collaborator Author

@twjeffery and @chrisolsen Hello I updated the docs site according to what we discuss. Let me know if there are anythings else. ☺️

@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/2850-temporary-notification-docs branch 2 times, most recently from dcc9f3c to f83c07a Compare July 17, 2025 21:55
@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/2850-temporary-notification-docs branch from f83c07a to 07ffdc8 Compare July 18, 2025 17:50
@vanessatran-ddi
Copy link
Collaborator Author

I resolved conversations so it is clean and we can review again. cc @twjeffery and @chrisolsen

@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/2850-temporary-notification-docs branch from 07ffdc8 to 550d5fb Compare July 18, 2025 20:57
@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/2850-temporary-notification-docs branch from 550d5fb to d1f7bf6 Compare July 18, 2025 21:15
@twjeffery twjeffery merged commit 9d7bb2d into alpha Jul 21, 2025
7 checks passed
@twjeffery twjeffery deleted the vanessa/2850-temporary-notification-docs branch July 21, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TemporaryNotification docs

3 participants