fix(#2732): Updating DatePicker component to include type property#427
Merged
ArakTaiRoth merged 4 commits intoalphafrom Sep 18, 2025
Merged
fix(#2732): Updating DatePicker component to include type property#427ArakTaiRoth merged 4 commits intoalphafrom
ArakTaiRoth merged 4 commits intoalphafrom
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
6 tasks
bdfranck
approved these changes
Sep 9, 2025
Collaborator
bdfranck
left a comment
There was a problem hiding this comment.
I looked at the deploy preview...
- ✅ I see the
typeproperty in the new versions - ✅ I don't see the
typeproperty in the LTS versions - ✅ I see the description for
typein the list of properties - ✅ I see the "Date of birth" example
@ArakTaiRoth Looks good! I noticed that we also have birthdate input example. Should we create a separate issue to update it? 🤔
https://deploy-preview-427--abgov-ui-component-docs.netlify.app/examples/ask-a-user-for-a-birthday
bdfranck
requested changes
Sep 17, 2025
Collaborator
bdfranck
left a comment
There was a problem hiding this comment.
I looked at the recent code changes.
- ✅ I can see that the old birthdate example is removed
- ✅ I can see that the example is no longer in the input examples
Looks good, @ArakTaiRoth! There's one tiny change: reduce the number on the Input examples tab from 6 to 5.
bdfranck
approved these changes
Sep 17, 2025
bdfranck
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



All changes made for both Angular and React, only their new versions
Added a new
typeproperty in the Date Picker sandboxUpdated the properties table with the new
typepropertyCreated a new example showing the
typeproperty in useUpdated descriptions for
minandmaxproperties that they are only for type="calendar"