Skip to content

fix(#2732): Updating DatePicker component to include type property#427

Merged
ArakTaiRoth merged 4 commits intoalphafrom
dustin/2732
Sep 18, 2025
Merged

fix(#2732): Updating DatePicker component to include type property#427
ArakTaiRoth merged 4 commits intoalphafrom
dustin/2732

Conversation

@ArakTaiRoth
Copy link
Collaborator

@ArakTaiRoth ArakTaiRoth commented Aug 26, 2025

All changes made for both Angular and React, only their new versions

Added a new type property in the Date Picker sandbox

Updated the properties table with the new type property

Created a new example showing the type property in use

Updated descriptions for min and max properties that they are only for type="calendar"

@netlify
Copy link

netlify bot commented Aug 26, 2025

Deploy Preview for abgov-ui-component-docs ready!

Name Link
🔨 Latest commit ed256f6
🔍 Latest deploy log https://app.netlify.com/projects/abgov-ui-component-docs/deploys/68cb0d10708cd80008d9d63a
😎 Deploy Preview https://deploy-preview-427--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 38
Accessibility: 93
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@ArakTaiRoth ArakTaiRoth marked this pull request as ready for review August 26, 2025 19:29
@ArakTaiRoth ArakTaiRoth requested review from bdfranck, mxsoco and twjeffery and removed request for mxsoco August 26, 2025 19:29
Copy link
Collaborator

@bdfranck bdfranck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the deploy preview...

  • ✅ I see the type property in the new versions
  • ✅ I don't see the type property in the LTS versions
  • ✅ I see the description for type in the list of properties
  • ✅ I see the "Date of birth" example

@ArakTaiRoth Looks good! I noticed that we also have birthdate input example. Should we create a separate issue to update it? 🤔

https://deploy-preview-427--abgov-ui-component-docs.netlify.app/examples/ask-a-user-for-a-birthday

Copy link
Collaborator

@bdfranck bdfranck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the recent code changes.

  • ✅ I can see that the old birthdate example is removed
  • ✅ I can see that the example is no longer in the input examples

Looks good, @ArakTaiRoth! There's one tiny change: reduce the number on the Input examples tab from 6 to 5.

Image

Copy link
Collaborator

@bdfranck bdfranck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the latest Preview...

  • ✅ I can see the correct number of examples in the tab label
Image

Looks good to me! 👍

Copy link
Collaborator

@bdfranck bdfranck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the preview of the latest changes...

  • ✅ I see the Example tab labels matches the number of examples
Image

Looks good to me! 👍

@ArakTaiRoth ArakTaiRoth merged commit 52481fd into alpha Sep 18, 2025
7 checks passed
@ArakTaiRoth ArakTaiRoth deleted the dustin/2732 branch September 18, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document type property for datepicker component and update for screen readers

3 participants