fix(#3123): docs update - badge icon type prop#450
Merged
ArakTaiRoth merged 1 commit intoGovAlta:alphafrom Nov 13, 2025
Merged
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
ArakTaiRoth
reviewed
Nov 6, 2025
syedszeeshan
force-pushed
the
Syed/3123-docs
branch
from
5acc894 to
8c5ca45
Compare
ArakTaiRoth
reviewed
Nov 6, 2025
src/routes/components/Badge.tsx
Outdated
| }, | ||
| { | ||
| label: "Icon type", | ||
| type: "string", |
Collaborator
There was a problem hiding this comment.
You have this set to a type of String, it would probably be better to treat this like we do Trailing and Leading Icon properties in other components.
syedszeeshan
force-pushed
the
Syed/3123-docs
branch
from
95b5431 to
6ad0ed7
Compare
vanessatran-ddi
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.