Skip to content

Conversation

@chrisolsen
Copy link
Collaborator

…: numberAttribute

Before (the change)

After (the change)

Make sure that you've checked the boxes below before you submit the PR

  • I have read and followed the setup steps
  • I have created necessary unit tests
  • I have tested the functionality in both React and Angular.

Steps needed to test

@ArakTaiRoth ArakTaiRoth self-requested a review May 14, 2025 21:50
Copy link
Collaborator

@vanessatran-ddi vanessatran-ddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested with all affected components in angular such as:

<h4>Test transform boolean</h4>
<goab-accordion open heading="Heading with open">
  It is goab-accordion open only
</goab-accordion>

<goab-accordion open="true" heading="Heading with open">
  It is goab-accordion open="true" only
</goab-accordion>

<goab-accordion [open]="true" heading="Heading with open">
  It is goab-accordion [open]="true" only
</goab-accordion>
<goab-accordion [open]="false" heading="Heading with open">
  It is goab-accordion [open]="false" only
</goab-accordion>

All are working well.

@chrisolsen chrisolsen requested a review from syedszeeshan June 2, 2025 18:50
@chrisolsen chrisolsen merged commit 1170df0 into alpha Jun 5, 2025
4 checks passed
@chrisolsen chrisolsen deleted the contributions/grant/property-transform branch June 5, 2025 14:40
@tzuge
Copy link
Collaborator

tzuge commented Jun 5, 2025

🎉 This PR is included in version 1.5.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 5, 2025

🎉 This PR is included in version 4.5.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label Jun 5, 2025
@tzuge
Copy link
Collaborator

tzuge commented Jun 5, 2025

🎉 This PR is included in version 1.34.1-alpha.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 5, 2025

🎉 This PR is included in version 6.5.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 16, 2025

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 16, 2025

🎉 This PR is included in version 1.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Jun 16, 2025
@tzuge
Copy link
Collaborator

tzuge commented Jun 16, 2025

🎉 This PR is included in version 4.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 16, 2025

🎉 This PR is included in version 6.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released on @alpha Released into alpha. released Released into production.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants