-
Notifications
You must be signed in to change notification settings - Fork 34
transform tasks: introduced transform: booleanAttribute and transform… #2724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…: numberAttribute
vanessatran-ddi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested with all affected components in angular such as:
<h4>Test transform boolean</h4>
<goab-accordion open heading="Heading with open">
It is goab-accordion open only
</goab-accordion>
<goab-accordion open="true" heading="Heading with open">
It is goab-accordion open="true" only
</goab-accordion>
<goab-accordion [open]="true" heading="Heading with open">
It is goab-accordion [open]="true" only
</goab-accordion>
<goab-accordion [open]="false" heading="Heading with open">
It is goab-accordion [open]="false" only
</goab-accordion>
All are working well.
|
🎉 This PR is included in version 1.5.0-alpha.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.5.0-alpha.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.34.1-alpha.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.5.0-alpha.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…: numberAttribute
Before (the change)
After (the change)
Make sure that you've checked the boxes below before you submit the PR
Steps needed to test