Skip to content

Conversation

@syedszeeshan
Copy link
Collaborator

@syedszeeshan syedszeeshan commented May 14, 2025

Before (the change)

After (the change)

US-2526.mp4

Make sure that you've checked the boxes below before you submit the PR

  • I have read and followed the setup steps
  • I have created necessary unit tests
  • I have tested the functionality in both React and Angular.

Steps needed to test

import { GoAInputDateTime } from "@abgov/react-components";
import { useState } from "react";

export default function Input() {
  function noop() {
    // noop
  }

  const [date, setDate] = useState<Date | string>("");

  return (
    <GoAInputDateTime
      name={"ADSP test"}
      value={date}
      step={1}
      onChange={(name, value: Date | string) => {
        setDate(value);
        console.log(value);
      }}
    />
  );
}

@syedszeeshan syedszeeshan changed the base branch from alpha to lts May 14, 2025 21:14
@syedszeeshan syedszeeshan changed the title NOT READY - fix(#2526): date value mismatch seconds issue fix(#2526): date value mismatch seconds issue May 14, 2025
@vanessatran-ddi
Copy link
Collaborator

QA Passed: It works as expected:
image

@chrisolsen chrisolsen merged commit 077176f into lts May 16, 2025
3 checks passed
@chrisolsen chrisolsen deleted the Syed/2526-UI-LTS branch May 16, 2025 22:26
@tzuge
Copy link
Collaborator

tzuge commented May 16, 2025

🎉 This PR is included in version 5.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Date value mismatch between GoAInputDateTime component and its onChange event

5 participants