feat(#3370): Date Picker and and Calendar improvements by willcodeforcoffee · Pull Request #3376 · GovAlta/ui-components

willcodeforcoffee · 2026-01-30T01:55:55Z

Before (the change)

Lots of issues that are fixed in this PR:

After you selected January 31 you could not change the calendar to February, or any month with <31 days in it. There was a bug where the day selected would be kept, making it invalid and preventing the calendar redrawing (February 31 is not valid).
For the Calendar and DatePicker a new value is never propagated unless a date is clicked on.
When a date is selected in the Calendar that is the only day that is selected. Before, in some situations, if you selected a date like February 15, changing the month to March would show March 15 selected.
When a date is selected the Calendar might not show that day as selected if you changed the month or year, and then returned the calendar to the month of the selected date. For example if you selected February 15, 2026 and changed the month to March, changing it back might not show February 15, 2026 as selected anymore.

After (the change)

These things are all fixed!

There are a lot of changes that involve using .clone() with _currentDate and _selectedDate. This is because most of the errors were caused by using the same object references, so changes to one changed the other.

Unfortunately there are a few changes caused by Prettier also.

Make sure that you've checked the boxes below before you submit the PR

I have read and followed the setup steps
I have created necessary unit tests
I have tested the functionality in both React and Angular.

Steps needed to test

Given a date is selected, when the user navigates to a different month, then no day is visually selected in the calendar grid.
Given a date is selected, when the user navigates to a different year, then no day is visually selected in the calendar grid.
Given a date is selected, when the user navigates back to the selected date’s month/year, then the originally selected day is visually selected again in the calendar grid.
(DatePicker only) Given a date is selected, when the user navigates months/years, and closes the picker then the input value does not change
Given the calendar is showing a month/year that does not match the selected date, when the user selects a day, then:
- that new date becomes selected
- the calendar grid shows it as selected
- the input updates accordingly
- the calendar closes
For bug Can't select February in Date Picker #3305: if you select January 31 you can still select a date in February (28 days) or April (30 days)

vanessatran-ddi

The bug is fixed.

ArakTaiRoth · 2026-02-13T00:07:44Z

@chrisolsen This is ready to be merged

ArakTaiRoth · 2026-02-13T21:35:45Z

@chrisolsen This is ready to be merged

chrisolsen · 2026-02-17T23:47:45Z

🎉 This PR is included in version 1.41.0-dev.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-02-17T23:48:04Z

🎉 This PR is included in version 6.11.0-dev.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-02-17T23:48:24Z

🎉 This PR is included in version 4.11.0-dev.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-02-24T20:47:48Z

🎉 This PR is included in version 1.11.0-dev.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-02-27T18:31:18Z

🎉 This PR is included in version 1.41.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-02-27T18:33:29Z

🎉 This PR is included in version 1.11.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-02-27T18:35:42Z

🎉 This PR is included in version 6.11.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-02-27T18:37:52Z

🎉 This PR is included in version 4.11.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-02-27T19:36:55Z

🎉 This PR is included in version 1.41.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-02-27T19:39:05Z

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-02-27T19:41:17Z

🎉 This PR is included in version 6.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-02-27T19:43:28Z

🎉 This PR is included in version 4.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-31T23:25:12Z

🎉 This PR is included in version 2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-31T23:33:35Z

🎉 This PR is included in version 2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-31T23:42:00Z

🎉 This PR is included in version 7.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-31T23:50:39Z

🎉 This PR is included in version 5.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-04-01T00:34:05Z

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-04-01T00:42:29Z

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-04-01T00:50:51Z

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

willcodeforcoffee self-assigned this Jan 30, 2026

willcodeforcoffee commented Jan 30, 2026

View reviewed changes

Comment thread apps/prs/angular/src/app/app.routes.ts Outdated

willcodeforcoffee commented Jan 30, 2026

View reviewed changes

Comment thread apps/prs/react/src/main.tsx Outdated

willcodeforcoffee changed the title ~~feat(#3370): Date Picker and and Calendar can select months~~ feat(#3370): Date Picker and and Calendar improvements Jan 30, 2026

willcodeforcoffee force-pushed the eric/3370-calendar-improvements branch 2 times, most recently from ced0876 to 0c1c66e Compare February 4, 2026 20:50

This was linked to issues Feb 4, 2026

Clear calendar day selection when year and/or month changes #3370

Closed

Can't select February in Date Picker #3305

Closed

willcodeforcoffee requested review from ArakTaiRoth and vanessatran-ddi February 4, 2026 21:52

willcodeforcoffee commented Feb 4, 2026

View reviewed changes

Comment thread libs/angular-components/src/lib/components/calendar/calendar.ts

willcodeforcoffee force-pushed the eric/3370-calendar-improvements branch from 0c1c66e to f5643b9 Compare February 4, 2026 22:21

willcodeforcoffee commented Feb 4, 2026

View reviewed changes

Comment thread apps/prs/angular/src/app/app.component.html Outdated

willcodeforcoffee marked this pull request as ready for review February 4, 2026 22:27

ArakTaiRoth reviewed Feb 6, 2026

View reviewed changes

Comment thread libs/angular-components/src/lib/components/calendar/calendar.ts Outdated

Comment thread libs/web-components/src/components/calendar/Calendar.svelte

Comment thread libs/web-components/src/components/calendar/calendar.spec.ts Outdated

ArakTaiRoth force-pushed the eric/3370-calendar-improvements branch from f5643b9 to 53186d7 Compare February 6, 2026 00:11

ArakTaiRoth reviewed Feb 6, 2026

View reviewed changes

Comment thread libs/angular-components/src/lib/components/calendar/calendar.ts

willcodeforcoffee force-pushed the eric/3370-calendar-improvements branch 2 times, most recently from 6fec990 to 13b4a79 Compare February 6, 2026 23:14

willcodeforcoffee requested a review from ArakTaiRoth February 9, 2026 16:19

vanessatran-ddi previously approved these changes Feb 9, 2026

View reviewed changes

willcodeforcoffee dismissed vanessatran-ddi’s stale review via 7e5ac15 February 12, 2026 22:32

willcodeforcoffee force-pushed the eric/3370-calendar-improvements branch from 13b4a79 to 7e5ac15 Compare February 12, 2026 22:32

willcodeforcoffee requested a review from vanessatran-ddi February 12, 2026 23:07

ArakTaiRoth previously approved these changes Feb 12, 2026

View reviewed changes

vanessatran-ddi previously approved these changes Feb 13, 2026

View reviewed changes

chrisolsen reviewed Feb 13, 2026

View reviewed changes

Comment thread libs/web-components/src/components/calendar/Calendar.svelte

Comment thread libs/web-components/src/components/calendar/Calendar.svelte

Comment thread libs/web-components/src/components/calendar/Calendar.svelte

willcodeforcoffee dismissed stale reviews from vanessatran-ddi and ArakTaiRoth via b232370 February 13, 2026 21:03

willcodeforcoffee force-pushed the eric/3370-calendar-improvements branch from 7e5ac15 to b232370 Compare February 13, 2026 21:03

chrisolsen approved these changes Feb 13, 2026

View reviewed changes

ArakTaiRoth approved these changes Feb 13, 2026

View reviewed changes

feat(#3370): Clear calendar day selection when year and/or month changes

19eaef7

willcodeforcoffee force-pushed the eric/3370-calendar-improvements branch from b232370 to 19eaef7 Compare February 17, 2026 23:02

chrisolsen merged commit e1015f9 into dev Feb 17, 2026
4 checks passed

chrisolsen deleted the eric/3370-calendar-improvements branch February 17, 2026 23:41

chrisolsen added the released on @dev label Feb 17, 2026

chrisolsen added the released on @next label Feb 27, 2026

chrisolsen added the released Released into production. label Feb 27, 2026

Conversation

willcodeforcoffee commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before (the change)

After (the change)

Make sure that you've checked the boxes below before you submit the PR

Steps needed to test

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vanessatran-ddi left a comment

Choose a reason for hiding this comment

Uh oh!

ArakTaiRoth commented Feb 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ArakTaiRoth commented Feb 13, 2026

Uh oh!

Uh oh!

chrisolsen commented Feb 17, 2026

Uh oh!

chrisolsen commented Feb 17, 2026

Uh oh!

chrisolsen commented Feb 17, 2026

Uh oh!

chrisolsen commented Feb 24, 2026

Uh oh!

chrisolsen commented Feb 27, 2026

Uh oh!

chrisolsen commented Feb 27, 2026

Uh oh!

chrisolsen commented Feb 27, 2026

Uh oh!

chrisolsen commented Feb 27, 2026

Uh oh!

chrisolsen commented Feb 27, 2026

Uh oh!

chrisolsen commented Feb 27, 2026

Uh oh!

chrisolsen commented Feb 27, 2026

Uh oh!

chrisolsen commented Feb 27, 2026

Uh oh!

chrisolsen commented Mar 31, 2026

Uh oh!

chrisolsen commented Mar 31, 2026

Uh oh!

chrisolsen commented Mar 31, 2026

Uh oh!

chrisolsen commented Mar 31, 2026

Uh oh!

chrisolsen commented Apr 1, 2026

Uh oh!

chrisolsen commented Apr 1, 2026

Uh oh!

chrisolsen commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

willcodeforcoffee commented Jan 30, 2026 •

edited

Loading