feat(#1553): add 401, 404, 500 error page examples#3853
Merged
ArakTaiRoth merged 2 commits intodevfrom Apr 28, 2026
Merged
Conversation
✅ Deploy Preview for benji-docs-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
07f8fae to
f3b015b
Compare
Collaborator
Author
|
Thanks @vanessatran-ddi. All comments addressed:
Two things:
|
willcodeforcoffee
approved these changes
Apr 24, 2026
Collaborator
willcodeforcoffee
left a comment
There was a problem hiding this comment.
This looks great! Thanks a lot, Tom.
ArakTaiRoth
reviewed
Apr 27, 2026
|
Preview removedAll preview folders cleaned from gh-pages branch. |
Collaborator
|
🎉 This PR is included in version 7.0.0-dev.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 5.0.0-dev.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 2.0.0-dev.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 2.0.0-dev.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/src/content/examples/. Each covers React, Angular, and Web Components.GoabPageBlock,GoabBlock,GoabIcon,GoabText,GoabButton,GoabLink). A small amount of class-based CSS covers the icon-in-circle, brand accent bar, centred text, and the icon scaled beyondxlarge.roleon the React and Angular icon wrappers (feat(#3871), issue Exposeroleprop on React and Angular icon wrappers #3871) so decorative icons can userole="presentation". Came up during review.Custom things that could be components (maybe)
The examples surfaced a few gaps thinking about if we would ever want components for:
xlarge(2.5rem cap) for page-scale illustrations.textAlignprop onGoabTextfor centred layouts where body copy wraps.Test plan
/examples/404-error-page,/examples/401-error-page,/examples/500-error-pagerender with the correct visual treatment.GoabPageBlock.accessibilityNotes.