TECH-318: Add API calls to building block table component #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dszafranek
requested changes
Mar 9, 2023
| <div></div> | ||
| <div className='sub-table-row-bb' data-testid='bb-name'> | ||
| <BBImage imagePath={buildingBlock.buildingBlock} /> | ||
| <p>{(buildingBlock.buildingBlock).replace(/bb-|-/g, ' ')}</p> |
Contributor
There was a problem hiding this comment.
Instead of manipulating a string, I would prefer a service/function that handles mapping from identifiers received from the server to a user-friendly display string.
We could use the value from the server as a translation key (bb-digital-registries), if no translation is found we could fall back to string manipulation as you did in the current solution.
Contributor
Author
There was a problem hiding this comment.
I really like your idea! I'm going to handle it while working on a ticket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add API calls to building block table component.
Ticket: https://govstack-global.atlassian.net/browse/TECH-318
Implemented solution detail:
with error fetching data
without error
