Skip to content

TECH-1047: Add placeholder text to empty assessment entries #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lruzicki merged 2 commits into from
Jul 5, 2024
Merged

TECH-1047: Add placeholder text to empty assessment entries #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7a9297
TECH-1047: Add placeholder text to empty assessment entries
Jul 4, 2024
83e71b6
TECH-1047: fix, there was an issue with refresing report view details…
Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions frontend/components/compliance/ReportViewDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ const ReportViewDetail = () => {
const data = await getSoftwareDetailsReport(softwareId as string);
if (data.status) {
setSoftwareDetailsData(data.data);

}
}
};
Expand Down Expand Up @@ -154,14 +155,14 @@ const ReportViewDetail = () => {
</Link>
</div>
)}
{activeTab === 'interface' && (
{activeTab === 'interface' && softwareDetailsData !== undefined && (
<SelectBBs
interfaceRequirementsData={requirementsData}
readOnlyView={true}
readOnlyData={softwareDetailsData}
/>
)}
{activeTab === 'specification' && (
{activeTab === 'specification' && softwareDetailsData !== undefined && (
<RequirementSpecificationSelectBBs
interfaceRequirementsData={requirementsData}
readOnlyView={true}
Expand Down
7 changes: 6 additions & 1 deletion frontend/components/shared/combined/RequirementSpecificationSelectBB.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ const RequirementSpecificationSelectBBs = ({
handleSetOptions={handleSetOptions}
/>
)}
{selectedItems.length > 0 && (
{selectedItems.length > 0 ? (
<div>
<div className="pills-container">
{readOnlyView ? (
Expand All @@ -497,6 +497,11 @@ const RequirementSpecificationSelectBBs = ({
</div>
{displayTable}
</div>
) : (
<div>
{format('app.view_report_details.noInformation',
{ section: `${format('table.requirement_specification_compliance.label')}` })}
</div>
)}
</div>
);
Expand Down
7 changes: 6 additions & 1 deletion frontend/components/shared/combined/SelectBBs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ const SelectBBs = ({
handleSetOptions={handleSetOptions}
/>
)}
{selectedItems.length > 0 && (
{selectedItems.length > 0 ? (
<div>
<div className="pills-container">
{readOnlyView ? (
Expand All @@ -429,6 +429,11 @@ const SelectBBs = ({
</div>
{displayTable}
</div>
) : (
<div>
{format('app.view_report_details.noInformation',
{ section: `${format('table.interface_compliance.label')}` })}
</div>
)}
</div>
);
Expand Down
1 change: 1 addition & 0 deletions frontend/translations/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export const en = {
'app.software_requirements_compliance.label':
'Software Requirements Compliance',
'app.view_report_details.label': 'View report details',
'app.view_report_details.noInformation': 'Information has not been provided for the {section} of the compliance form',

'building_block.label': 'Building Block',
'building_block.plural.label': 'Building Blocks',
Expand Down