Skip to content

Conversation

@dborowiecki
Copy link
Contributor

@dborowiecki dborowiecki commented Apr 26, 2023

Ticket: TECH-417

Supported sorting keys:

sort.testApp
sort.testSuite
sort.sourceBranch
sort.overallCompatibility

Copy link
Contributor

@mgrochalskisoldevelo mgrochalskisoldevelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing to discuss I see is:

image

When we invoke the request multiple times data in compatibilities may be returned in different order. What do you think about it @dborowiecki should we add some kind of built in sorting mechanism to avoid it? except that lgtm

@dborowiecki
Copy link
Contributor Author

dborowiecki commented Apr 27, 2023

@mgrochalskisoldevelo good catch with the compatibilities inconsistency. I don't think it's related to changes in PR. However, I added fix to the pipeline in this PR.

When you've mentioned compatibilities, I've noticed that we are sorting the projects by their ID. I think we could sort by saveTime so most recent products are shown first, but we need to discuss it with commitee first.

@KarolinaKopacz KarolinaKopacz merged commit 3c7c2b5 into main Apr 27, 2023
@dborowiecki dborowiecki deleted the feature/TECH-417 branch April 27, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants