Feature/state separation #4
Conversation
Moved mainController to signatureValidatorController. Moved controllers and associated templates to features/ folder. Controllers and templates are now imported using webpack instead of angular DI.
Aligned styles between signature and JOSE validator.
robincher
left a comment
robincher
left a comment
There was a problem hiding this comment.
Can update the readme.md with the new screenshots
src/features/paramsModal.js
Outdated
| Cancel | ||
| </button> | ||
| </div> | ||
| ` |
There was a problem hiding this comment.
Can remove this orphan characters also.
robincher
left a comment
robincher
left a comment
There was a problem hiding this comment.
Additionally, just ensure the missing semi colons etc are added and bring down the code quality issues that are avoidable.
Made code neater.
|
Hi @weijunyu , Before you merge, remember to update the ChangeLog and commit it. |
README.md
Outdated
|
|
||
| ### Decrypting JWE | ||
|  | ||
|  |
There was a problem hiding this comment.
Broken Image link
Should be 
README.md
Outdated
|
|
||
| ### Verifying JWS | ||
|  | ||
|  |
There was a problem hiding this comment.
Broken Image link
Should be like this
Updated var declarations and code style.
Description
Separated JOSE and signature validator into separate states.
Fixes # (issue number)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Manually using test files provided.