Added functionality to handle json test cases. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CommonExtensions.cs: * storage.ide: * storage.ide-wal: updated testcase * UserPrefs.xml: updated
* TestDataTest.cs: * storage.ide: * storage.ide-shm: * storage.ide-wal: added get L2 signature * UserPrefs.xml: added L2
Added functionality to handle json test cases.
Contributor
|
@punjabisingh Please fix the quality issues and failing builds first. The CI is throwing this error |
robincher
reviewed
Sep 28, 2018
CHANGELOG.md
Outdated
| # Change Log | ||
|
|
||
| ## Added | ||
| <<<<<<< HEAD |
Contributor
There was a problem hiding this comment.
Can resolve the conflicts and update the new version for change log?
robincher
suggested changes
Sep 28, 2018
Contributor
robincher
left a comment
robincher
left a comment
There was a problem hiding this comment.
General feedback
- Fix avoidable quality issues mentioned by codacy
- Resolve the conflicts of CHANGELOG.md
- Is it necessary to upload the binary files inside .vs/ ? If not, please gitignore them.
updated comments.md
robincher
reviewed
Sep 28, 2018
CHANGELOG.md
Outdated
| + 2017-10-29 - Initial release. | ||
|
|
||
| ### V1.1-SNAPSHOT | ||
| + 2018-09-10 - Bug Fixes. |
updated comments.md
updated comments.md
robincher
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested using json formated test case. These test cases are same for all the utilities and making sure all test cases pases.