chore: fix 67 ruff violations across SDK (unblock CI)

[Gradata]

Summary

• Fixes all ruff lint errors on main that were blocking CI (67 violations across 15 files)
• No behavior changes — purely lint cleanups (F401, SIM102/103/105/117, RUF022, TC001, UP037)
• Follow-up to PR feat(jit,graduation): BM25 for JIT ranking + raise Beta LB default to 0.85 #101; unblocks clean CI green for future PRs

Key changes

• enhancements/self_improvement/__init__.py — add __all__ to re-export hub (silences 45 F401)
• _file_lock.py — contextlib.suppress(OSError) replaces 2 try/except/pass
• _events.py — collapse nested with open / with platform_lock into single-line
• rule_enforcement.py — simplify boolean return
• _graduation.py — combine nested if in domain filter
• rule_engine/_models.py — move Lesson import into TYPE_CHECKING
• rule_engine/__init__.py — sort __all__

Test plan

• ruff check src/gradata/ → all checks passed
• pytest tests/ → 3670 passed, 21 skipped, 2 xfailed
• Pre-existing flaky Windows cp1252 test_cli_export_writes_cursorrules is unrelated

Generated with Gradata

[greptile-apps]

Gradata has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5a2d6f42-e6ca-4da6-8bb9-23a784d45ca6

📥 Commits

Reviewing files that changed from the base of the PR and between cedd97a and 9c50b6d.

📒 Files selected for processing (15)

• src/gradata/_encryption.py
• src/gradata/_events.py
• src/gradata/_file_lock.py
• src/gradata/cli.py
• src/gradata/enhancements/behavioral_extractor.py
• src/gradata/enhancements/llm_synthesizer.py
• src/gradata/enhancements/self_improvement/__init__.py
• src/gradata/enhancements/self_improvement/_confidence.py
• src/gradata/hooks/dispatch_post.py
• src/gradata/hooks/rule_enforcement.py
• src/gradata/middleware/_core.py
• src/gradata/rules/rule_engine/__init__.py
• src/gradata/rules/rule_engine/_formatting.py
• src/gradata/rules/rule_engine/_models.py
• src/gradata/rules/rule_engine/_scoring.py

💤 Files with no reviewable changes (8)

• src/gradata/enhancements/behavioral_extractor.py
• src/gradata/middleware/_core.py
• src/gradata/enhancements/llm_synthesizer.py
• src/gradata/_encryption.py
• src/gradata/enhancements/self_improvement/_confidence.py
• src/gradata/rules/rule_engine/_scoring.py
• src/gradata/cli.py
• src/gradata/rules/rule_engine/_formatting.py

📜 Recent review details

🧰 Additional context used

📓 Path-based instructions (2)

src/gradata/**/*.py

⚙️ CodeRabbit configuration file

src/gradata/**/*.py: This is the core SDK. Check for: type safety (from future import annotations required), no print()
statements (use logging), all functions accepting BrainContext where DB access occurs, no hardcoded paths. Severity
scoring must clamp to [0,1]. Confidence values must be in [0.0, 1.0].

Files:

• src/gradata/rules/rule_engine/_models.py
• src/gradata/_events.py
• src/gradata/_file_lock.py
• src/gradata/hooks/dispatch_post.py
• src/gradata/hooks/rule_enforcement.py
• src/gradata/enhancements/self_improvement/__init__.py
• src/gradata/rules/rule_engine/__init__.py

src/gradata/hooks/**

⚙️ CodeRabbit configuration file

src/gradata/hooks/**: JavaScript hooks for Claude Code integration. Check for: no shell injection (no execSync with user
input), temp files must use per-user subdirectory, HTTP calls must have timeouts, errors must be silent (never block
the tool chain).

Files:

• src/gradata/hooks/dispatch_post.py
• src/gradata/hooks/rule_enforcement.py

🔇 Additional comments (10)

src/gradata/hooks/rule_enforcement.py (1)

98-98: Boolean simplification is correct and preserves behavior.

Line 98 keeps the same domain-mismatch semantics while making the return path clearer.

src/gradata/hooks/dispatch_post.py (1)

71-72: Result collection update is safe and idiomatic.

Line 71 preserves truthy-only concatenation behavior while simplifying the key check.

src/gradata/enhancements/self_improvement/__init__.py (2)

24-34: Explicit type re-exports are correct and preserve import compatibility.

This keeps from gradata.enhancements.self_improvement import ... stable for core shared types and transition.

---

80-129: __all__ definition is well-scoped and consistent with imported symbols.

Good explicit public surface declaration; this cleanly addresses linting without changing behavior.

src/gradata/rules/rule_engine/_models.py (1)

10-13: LGTM! Correct TYPE_CHECKING pattern.

The conditional import of Lesson for type checking only is safe and follows best practices. With from __future__ import annotations (line 7), the type annotation on line 32 becomes a string at runtime, and dataclasses don't validate types at runtime, so the actual Lesson class is only needed for static type checkers.

src/gradata/rules/rule_engine/__init__.py (1)

64-110: LGTM! all sorted correctly.

The alphabetical sorting of __all__ satisfies the RUF022 lint rule. The section comments (# engine, # scoring, etc.) serve as organizational markers but don't strictly group items by their source module—for instance, _ELIGIBLE_STATES (imported from _engine at line 17) appears after the # scoring comment. This is minor and doesn't affect functionality.

src/gradata/_file_lock.py (3)

45-46: LGTM! Import modernization aligns with PEP 585.

Moving Generator to collections.abc follows Python 3.9+ best practices. The change is correct and improves compatibility with modern type checking.

---

113-114: LGTM! Cleaner exception handling with contextlib.suppress.

Replacing try/except OSError: pass with contextlib.suppress(OSError) is more idiomatic and aligns with ruff SIM105. The behavior is preserved—unlock errors are silently ignored as intended.

---

157-158: LGTM! Consistent refactor across platform implementations.

Applying the same contextlib.suppress(OSError) pattern to the POSIX unlock maintains symmetry with the Windows implementation. Both platforms now use idiomatic error handling.

src/gradata/_events.py (1)

48-53: LGTM! Combining context managers improves readability.

The refactor from nested with statements to a single multi-context with statement is semantically equivalent and cleaner. The exit order is preserved: platform_lock exits first (unlocking the file in its finally block), then the file handle closes. This matches ruff SIM117.

---

📝 Walkthrough

Ruff Lint Cleanup

• Fixed 67 ruff violations across 15 files (F401, SIM102/103/105/117, RUF022, TC001, UP037) to unblock CI; no behavioral changes
• Removed unused imports (os, typing.Generator) from multiple modules (_encryption.py, llm_synthesizer.py, _core.py, cli.py, _scoring.py)
• Added __all__ export list to enhancements/self_improvement/__init__.py (61 lines) to explicitly enumerate public API and silence F401 violations for re-exported symbols
• Simplified error handling: replaced try/except OSError: pass with contextlib.suppress(OSError) in _file_lock.py
• Combined nested context managers in _events.py: merged with open() and with platform_lock() into single-line context manager
• Moved runtime imports to TYPE_CHECKING: shifted Lesson import to conditional block in rule_engine/_models.py to reduce startup dependencies
• Simplified boolean logic: replaced explicit conditional return with direct negation in rule_enforcement.py
• Reordered __all__ in rule_engine/init.py for consistency; reorganized exports into commented sections (engine, scoring, formatting)
• Minor whitespace cleanup: removed extraneous blank lines in behavioral_extractor.py, _formatting.py
• Test results: ruff check passed; pytest: 3,670 passed, 21 skipped, 2 xfailed

Walkthrough

This PR performs code quality improvements across the gradata codebase: removing unused imports, refactoring context managers and exception handling, converting a runtime import to TYPE_CHECKING guards, adding explicit __all__ declarations, reordering exported symbols, and simplifying logic conditions.

Changes

Cohort / File(s)	Summary
Unused Import Cleanup src/gradata/_encryption.py, src/gradata/enhancements/llm_synthesizer.py, src/gradata/middleware/_core.py, src/gradata/cli.py, src/gradata/enhancements/self_improvement/_confidence.py	Removed unused os imports and simplified from gradata._types imports. No functional behavior changed.
Context Manager & Exception Handling Refactoring src/gradata/_events.py, src/gradata/_file_lock.py	Consolidated nested with statements into single context manager; replaced try/except OSError: pass with contextlib.suppress(OSError). Behavior preserved.
Type Import Reorganization src/gradata/_file_lock.py, src/gradata/rules/rule_engine/_models.py, src/gradata/rules/rule_engine/_scoring.py	Moved Generator from typing to collections.abc; converted Lesson import to TYPE_CHECKING guard; removed unused TYPE_CHECKING block.
API Export Declaration src/gradata/enhancements/self_improvement/__init__.py	Added explicit __all__ list enumerating public re-exports including constants, functions, and types from submodules.
Export Reordering src/gradata/rules/rule_engine/__init__.py	Reorganized __all__ entries into logical sections (engine, scoring, formatting); no symbols added or removed.
Logic Refactoring src/gradata/hooks/dispatch_post.py, src/gradata/hooks/rule_enforcement.py	Simplified result-collection check using .get() instead of membership test; replaced conditional early-return with boolean negation expression.
Formatting Cleanup src/gradata/enhancements/behavioral_extractor.py, src/gradata/rules/rule_engine/_formatting.py	Removed extra blank lines between sections.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix(sdk): resolve 10 pyright type errors blocking CI #29: Modifies the Lesson dataclass in src/gradata/_types.py, directly related to this PR's conversion of Lesson import to TYPE_CHECKING guard.

Suggested labels

refactor

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: fix 67 ruff violations across SDK (unblock CI)' directly and accurately summarizes the main change: fixing ruff lint violations to unblock CI.
Description check	✅ Passed	The description comprehensively explains the changes: 67 ruff lint violations fixed across 15 files with no behavior changes, lists key files modified, and includes test results confirming the fixes work correctly.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/ruff-cleanup

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}