chore: untrack private files leaking into public repo#125
Merged
Conversation
`git ls-files -ci --exclude-standard` surfaced 31 files that were tracked on main but matched gitignore rules — meaning they ship in the public repo and PyPI wheel even though they're marked private. Removing from tracking (keeping on local disk): - Sprites/brain/scripts/* (24 files) — private sales/brain scripts that leaked into the public SDK repo. Include cloud_rls_test.sql, cloud_schema.sql, tenant migration scripts, ablation harness code. - Gradata/docs/superpowers/* (5 files) — internal session-plan docs - Gradata/docs/RELEASE-v0.5.0-DRAFT.md — unpublished release draft - Gradata/src/gradata/demo/brain/brain.manifest.json — generated artifact that shouldn't be in the wheel Also removing `Gradata/docs/cloud/` from .gitignore — those are legitimate public cloud-product docs and were shipping correctly; the ignore rule was historical cruft. After this: `git ls-files -ci --exclude-standard` → empty. Nothing private ships. Co-Authored-By: Gradata <noreply@gradata.ai>
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (32)
📝 Walkthrough
WalkthroughThis pull request removes approximately 30+ files across documentation, scripts, and configuration directories, including release/planning documents, demonstration assets, and standalone Python/SQL utility scripts. All changes are deletions with no new files or modifications. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git ls-files -ci --exclude-standardsurfaced 31 files tracked on main that match gitignore rules — these currently ship in the public repo and the PyPI wheel even though they're marked private.Untracked (kept on local disk):
Sprites/brain/scripts/*— 24 files (tenant migrations, cloud SQL schemas, ablation harness, brain benchmark, mirofish sim, autoresearch scripts)Gradata/docs/superpowers/*— 5 internal session-plan docsGradata/docs/RELEASE-v0.5.0-DRAFT.md— unpublished release draftGradata/src/gradata/demo/brain/brain.manifest.json— generated artifact in the wheelAlso: remove
Gradata/docs/cloud/from.gitignore— those are legitimate public cloud-product docs that were shipping correctly; the ignore rule was historical cruft.After this PR,
git ls-files -ci --exclude-standardreturns empty. Nothing private ships.Test plan
git ls-files -ci --exclude-standard→ 0 lines--cachedonly, not working-tree delete)Generated with Gradata