fix: CodeRabbit follow-ups from #144 + #141 (incl. critical /api/v1 double-prefix)

[Gradata]

Applies 11 CR action items. Critical: cloud_sync double /api/v1 prefix broke telemetry + corpus POSTs in prod.

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6a255861-6270-4df4-805c-9e1bed621cb2

📥 Commits

Reviewing files that changed from the base of the PR and between fbf8dbb and 78f527b.

📒 Files selected for processing (8)

• Gradata/src/gradata/cli.py
• Gradata/src/gradata/cloud/sync.py
• Gradata/src/gradata/enhancements/skill_export.py
• Gradata/src/gradata/hooks/implicit_feedback.py
• Gradata/src/gradata/hooks/inject_brain_rules.py
• Gradata/tests/test_cloud_sync.py
• Gradata/tests/test_hooks_intelligence.py
• Gradata/tests/test_skill_export.py

---

📝 Walkthrough

Summary

• Critical fix: Removed double /api/v1 prefix in cloud/sync.py POST paths for telemetry and corpus endpoints, correcting routing that was broken in production
• Improved brain root resolution in skill export by resolving brain_root once before creating Brain instance instead of falling back to CWD
• Enhanced YAML frontmatter generation with backslash escaping for valid Windows-style paths and literal sequences
• Refined description handling in skill export to treat whitespace-only descriptions as auto-generation triggers (falling back to synthesized descriptions)
• Modified implicit feedback hook to make negative feedback signals override approval patterns when both present in same message
• Hardened GRADATA_WISDOM_MAX_RULES environment variable parsing to emit warning and fall back to default (9) instead of crashing on invalid values
• Updated cloud sync and hooks intelligence tests to match corrected endpoint paths and tightened assertion specificity
• Added regression test coverage for YAML backslash/newline/whitespace handling in skill export

Walkthrough

The PR addresses multiple bug fixes and logic improvements: correcting Brain instantiation in the CLI export command, updating cloud sync endpoint paths to rely on pre-configured API base URLs, enhancing YAML description escaping for Windows paths, filtering conflicting feedback signals in hook processing, and adding environment variable validation to prevent runtime errors.

Changes

Cohort / File(s)	Summary
Skill Export Logic src/gradata/cli.py, src/gradata/enhancements/skill_export.py, tests/test_skill_export.py	Updated cmd_skill_export to instantiate Brain locally from resolved brain_root instead of calling _get_brain(). Enhanced YAML frontmatter escaping of backslashes before quotes for description fields. Extended test coverage with 4 new cases validating backslash escaping and whitespace fallback behavior.
Cloud Sync Endpoints src/gradata/cloud/sync.py, tests/test_cloud_sync.py	Removed hard-coded /api/v1 prefix from POST request paths for telemetry and corpus endpoints, relying on pre-configured config.api_base for versioning. Updated corresponding test assertions to expect unversioned paths.
Implicit Feedback Hook src/gradata/hooks/implicit_feedback.py, tests/test_hooks_intelligence.py	Added logic to suppress approval signals when negative feedback signals are detected, preventing conflicting OUTPUT_ACCEPTED emissions. Tightened test assertions to validate exact output payloads rather than substring matching.
Brain Rules Environment Validation src/gradata/hooks/inject_brain_rules.py	Added explicit validation for GRADATA_WISDOM_MAX_RULES environment variable with warning fallback instead of unconditional type casting, preventing runtime errors on unparseable values.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat(m1): skill export + cloud sync fixes #144: Modifies the same CLI and cloud sync files for skill export and endpoint routing refactoring.
• feat(jit,graduation): BM25 for JIT ranking + raise Beta LB default to 0.85 #101: Adjusts environment variable handling in the same inject_brain_rules.py file for rule thresholds.

Suggested labels

bug

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/coderabbit-followups

---

_{Review rate limit: 3/5 reviews remaining, refill in 19 minutes and 40 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}