fix(cloud/client): coerce float ts and non-int session for /sync

[Gradata]

Backfill discovered 2 type-coerce bugs in CloudClient:

1. TypeError on float ts values from JIT_INJECTION events → coerce to str
2. HTTP 422 on float/string session values → coerce to int|None
3. Surface HTTPError response body for future debugging

Found while running scripts/backfill_to_cloud.py against historical events.jsonl.

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 63a5c60b-8ced-4b9a-9412-95df96133b72

📥 Commits

Reviewing files that changed from the base of the PR and between b82a2dc and a3ae362.

📒 Files selected for processing (21)

• Gradata/pyproject.toml
• Gradata/src/gradata/_doctor.py
• Gradata/src/gradata/_events.py
• Gradata/src/gradata/brain.py
• Gradata/src/gradata/cli.py
• Gradata/src/gradata/cloud/client.py
• Gradata/src/gradata/enhancements/rule_pipeline.py
• Gradata/src/gradata/enhancements/scoring/retrieval_fusion.py
• Gradata/src/gradata/enhancements/self_improvement/_graduation.py
• Gradata/src/gradata/middleware/_core.py
• Gradata/tests/test_dualwrite_atomicity.py
• Gradata/tests/test_initial_confidence_invariant.py
• Gradata/tests/test_middleware_core.py
• Gradata/tests/test_retrieval_fusion.py
• Gradata/tests/test_rule_graduated_events.py
• Gradata/tests/test_rule_pipeline.py
• Gradata/tests/test_rule_to_hook.py
• Gradata/tests/test_rule_to_hook_promotion.py
• Gradata/tests/test_safety_assertion.py
• Gradata/tests/test_score_obfuscation_gate.py
• Gradata/tests/test_wiring_compound.py

---

📝 Walkthrough

Walkthrough

This PR implements dual-write event reconciliation for durability, reverses the Beta LB gate default to enabled, obfuscates confidence scores in prompts for security, reorganizes retrieval-fusion imports, and adds type coercion improvements to cloud client event handling.

Changes

Dual-Write Event Reconciliation & Brain Initialization

Layer / File(s)	Summary
Reconciliation Core src/gradata/_events.py	Adds _insert_event_projection() for idempotent tenant-scoped SQLite inserts and reconcile_jsonl_to_sqlite() to replay canonical JSONL into SQLite with drift/invalid-line metrics; emit() now uses _insert_event_projection() and respects GRADATA_DUALWRITE_JSONL_FSYNC_DELAY_MS before SQLite commit.
Brain Path Resolution src/gradata/_doctor.py	Adds public resolve_brain_path(brain_dir) wrapper to normalize brain directory resolution; _probe_api() error handling now uses contextlib.suppress().
Brain Integration src/gradata/brain.py	Brain.__init__ accepts optional brain_dir, resolves via resolve_brain_dir(), and runs reconcile_jsonl_to_sqlite() post-migration (swallowing errors at debug level); observe() signature changed to accept `messages: list[dict]
CLI Reconciliation Command src/gradata/cli.py	Adds --reconcile flag to gradata doctor that runs reconciliation, reports drift/replayed/counts, and exits early, skipping standard diagnostics.
Durability Tests tests/test_dualwrite_atomicity.py	Six comprehensive tests validate dual-write agreement, JSONL-as-canonical under kill-9, SQLite replay via reconciliation, idempotent re-initialization, doctor --reconcile healing, and concurrent-writer serialization; includes subprocess crash simulation and drift tolerance.
Configuration pyproject.toml	Adds dualwrite pytest marker for test classification.

Beta LB Gate Default Reversal

Layer / File(s)	Summary
Core Behavior src/gradata/enhancements/self_improvement/_graduation.py	_read_beta_lb_config() now defaults gate to enabled ("1" when unset) and disables only for "0", "false", "no", or "off"; docstring updated to reflect enabled-by-default contract.
Test Enforcement tests/test_*.py (7 files)	Multiple tests explicitly set GRADATA_BETA_LB_GATE=0 via monkeypatch to test behavior under the gate-disabled condition, ensuring consistent test outcomes across the new default.

Confidence Obfuscation & Score Security

Layer / File(s)	Summary
Middleware Obfuscation src/gradata/middleware/_core.py	build_brain_rules_block() now obfuscates each rendered rule line via obfuscate_instruction() instead of inserting raw confidence-annotated text.
Output Assertion Updates tests/test_middleware_core.py	Assertions updated to expect obfuscated [RULE] markers instead of confidence-parameterized [RULE:0.95] format.
Obfuscation Validation tests/test_score_obfuscation_gate.py	New module with regex-based assertion that no raw confidence floats leak into prompt text; covers both Brain.apply_brain_rules() and build_brain_rules_block() outputs.

Module Reorganization & Type Robustness

Layer / File(s)	Summary
Import Path Updates src/gradata/enhancements/rule_pipeline.py, tests/test_retrieval_fusion.py, tests/test_rule_pipeline.py	Retrieval-fusion utilities moved from gradata.enhancements.retrieval_fusion to gradata.enhancements.scoring.retrieval_fusion; all import statements updated consistently.
Cloud Client Type Coercion src/gradata/cloud/client.py	sync() coerces event ts to string before watermark comparison; _format_event() normalizes ts to string and converts session to int | None with explicit type-handling rules; _post() appends HTTP error body snippet (up to 500 chars) to ConnectionError message.
Additional Test Updates tests/test_initial_confidence_invariant.py	New module validating that lessons with initial confidence remain in INSTINCT state and threshold-boundary promotion logic.

Sequence Diagram(s)

sequenceDiagram
    participant BrainInit as Brain.__init__
    participant MigDB as DB Migrations
    participant ReconcileFunc as reconcile_jsonl_to_sqlite
    participant JSONL as events.jsonl
    participant SQLite as system.db
    participant Logger as Log (debug)

    BrainInit->>MigDB: run_migrations()
    MigDB->>SQLite: CREATE/ALTER tables
    BrainInit->>ReconcileFunc: reconcile_jsonl_to_sqlite(ctx)
    ReconcileFunc->>JSONL: Read events.jsonl
    alt JSONL exists
        ReconcileFunc->>JSONL: Parse & validate JSON lines
        ReconcileFunc->>SQLite: INSERT OR IGNORE per event
        ReconcileFunc->>ReconcileFunc: Track drift, replayed, invalid counts
        ReconcileFunc-->>BrainInit: Return metrics
    else JSONL missing/error
        ReconcileFunc-->>Logger: Log exception at debug level
        ReconcileFunc-->>BrainInit: Swallow error, continue
    end
    BrainInit->>BrainInit: Initialization complete

Loading

sequenceDiagram
    participant User as User / CLI
    participant CliCmd as gradata doctor --reconcile
    participant ResolvePath as resolve_brain_path
    participant Recon as reconcile_jsonl_to_sqlite
    participant Output as Output (JSON/text)

    User->>CliCmd: Run with --reconcile flag
    CliCmd->>ResolvePath: Resolve brain_dir
    alt Brain dir resolved
        ResolvePath-->>CliCmd: Return Path
        CliCmd->>Recon: Run reconciliation
        Recon-->>CliCmd: Return metrics dict
        CliCmd->>Output: Format & print drift, replayed, counts
        CliCmd->>User: Exit success
    else Brain dir not found
        ResolvePath-->>CliCmd: Return None
        CliCmd->>Output: Print error to stderr
        CliCmd->>User: Exit code 1
    end

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

• fix: P0 council bug fixes (atomic writes, BRAIN_DIR hard-fail, thread-safety) [rebased] #153: Modifies brain-directory resolution and doctor diagnostics, touching similar _doctor.py concerns with path handling and error semantics.
• feat(sdk): middleware adapters for OpenAI / Anthropic / LangChain / CrewAI #32: Introduces middleware core foundations; this PR modifies build_brain_rules_block() in the same file to add obfuscation logic.

Suggested labels

bug, enhancement

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/backfill-typecoerce

---

_{Review rate limit: 4/5 reviews remaining, refill in 12 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}