chore(sdk): prune 10 confirmed-dead modules (-3143 LOC)#90
Conversation
…test LOC) Deletes dead code flagged in the autoresearch leanness audit after grep-verifying that no runtime import path exists. All 2453 tests pass. Source files removed (2101 LOC): - src/gradata/contrib/enhancements/outcome_feedback.py (1 LOC, docstring stub) - src/gradata/enhancements/super_meta_rules.py (197 LOC, no importers; SuperMetaRule dataclass + SQL table live in meta_rules.py / meta_rules_storage.py and remain wired) - src/gradata/enhancements/pubsub_pipeline.py (49 LOC, test-only) - src/gradata/rules/budget.py (43 LOC, test-only) - src/gradata/rules/rw_lock.py (54 LOC, test-only) - src/gradata/cloud/wiki_store.py (451 LOC, only cloud/__init__.py re-export + test) - src/gradata/enhancements/rule_verifier.py (243 LOC, only manifest string + test reference) - src/gradata/enhancements/rule_evolution.py (434 LOC, only manifest string + test references; contradiction_detector.py covers the live path via self_improvement.py:545) - src/gradata/security/privacy_model.py (113 LOC, test + docs only; _core.py / brain.py / _export_brain.py grep-clean) - src/gradata/benchmarks/swe_bench.py (516 LOC, docstring example + test only, no CLI/docs runtime reference) Test files removed (1042 LOC): matching tests for each module plus targeted pruning of rule_evolution test classes (TestRuleConflicts, TestRuleRelationEnum, rule_evolution imports in TestIntegration) from tests/test_steals.py and the TestRuleABTesting block in tests/test_adaptations.py. Registry + docstring updates: - contrib/enhancements/install_manifest.py: drop rule_verifier from rule-integrity module components - _manifest_helpers.py: drop rule_evolution from _core_modules - enhancements/__init__.py: drop rule_verifier docstring line - cloud/__init__.py: drop WikiStore lazy re-export - enhancements/meta_rules_storage.py: docstring no longer points at the deleted super_meta_rules.py NOT DELETED (verified live via PRs #77/#81/#86): - enhancements/rule_ranker.py, self_healing.py, rule_canary.py, rule_to_hook.py (all have runtime callers) - middleware/ (flagged empty in the audit but actually contains _core.py + 4 adapters — kept) - src/gradata/graphify-out/ (did not exist in this tree) Tests: 2453 passed, 24 skipped (test_integration_full.py ignored per task spec). Co-Authored-By: Gradata <noreply@gradata.ai>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Gradata has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (25)
💤 Files with no reviewable changes (22)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🧰 Additional context used📓 Path-based instructions (1)src/gradata/**/*.py⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (3)
📝 WalkthroughBreaking Changes
WalkthroughThis PR removes multiple modules including enhancement tools (rule_evolution, rule_verifier, pubsub_pipeline, super_meta_rules), cloud features (WikiStore), utility infrastructure (budget, rw_lock, privacy_model), and benchmarking functionality (swe_bench), along with associated tests and manifest declarations. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
1 participant
Summary
Deletes 10 dead modules flagged in the autoresearch leanness audit after grep-verifying that no runtime import path exists. All 2453 tests pass.
-2101 LOC source, -1042 LOC tests, -3143 LOC total.
Deletions (grep-verification evidence)
src/gradata/contrib/enhancements/outcome_feedback.pysrc/gradata/enhancements/super_meta_rules.pyfrom ... super_meta_rules/import super_meta_rulesacross src/ and tests/;SuperMetaRuledataclass + SQL table live inmeta_rules.py/meta_rules_storage.pyand stay wiredsrc/gradata/enhancements/pubsub_pipeline.pytests/test_pubsub_pipeline.pysrc/gradata/rules/budget.pytests/test_budget_injection.pysrc/gradata/rules/rw_lock.pytests/test_rw_lock.pysrc/gradata/cloud/wiki_store.pycloud/__init__.pylazy re-export +tests/test_wiki_store.pysrc/gradata/enhancements/rule_verifier.pycontrib/enhancements/install_manifest.py:274string + tests + docssrc/gradata/enhancements/rule_evolution.py_manifest_helpers.py:125string +tests/test_adaptations.py+tests/test_steals.py; live contradiction path iscontradiction_detector.pyviaself_improvement.py:545src/gradata/security/privacy_model.pytests/test_privacy_model.py+security/THREAT_MODEL.md;_core.py,brain.py,_export_brain.pyall grep-cleansrc/gradata/benchmarks/swe_bench.pytests/test_swe_bench.py; no CLI/docs runtime referenceTest files removed
tests/test_{pubsub_pipeline,budget_injection,rw_lock,wiki_store,rule_verifier,privacy_model,swe_bench}.py+ targeted pruning of:tests/test_steals.py:TestRuleConflicts,TestRuleRelationEnum, rule_evolution imports inTestIntegrationtests/test_adaptations.py:TestRuleABTestingblock, rule_evolution entry in manifest-capabilities testRegistry + docstring updates
contrib/enhancements/install_manifest.py: dropenhancements.rule_verifierfrom rule-integrity components_manifest_helpers.py: droprule_evolutionfrom_core_modulesenhancements/__init__.py: droprule_verifierdocstring linecloud/__init__.py: dropWikiStorelazy re-exportenhancements/meta_rules_storage.py: docstring no longer points at deletedsuper_meta_rules.pyNOT deleted (verified live via recent PRs)
enhancements/rule_ranker.py(wired viarules.injectedemit in PR feat(wiring): canary + rules.injected + scipy Beta PPF + Beta LB gate #86)enhancements/self_healing.py(wired at_core.py:496in PR feat(self-healing): close the auto-heal loop, wire into brain.correct() (Phase 1) #77)enhancements/rule_canary.py(wired at_core.py:683in PR feat(wiring): canary + rules.injected + scipy Beta PPF + Beta LB gate #86)enhancements/rule_to_hook.py(wired atself_improvement.py:1189in PR feat(rule-to-hook): close auto-promotion loop in injection paths (Phase 5) #81)middleware/(flagged empty in the audit but actually contains_core.py+ 4 adapters)src/gradata/graphify-out/(does not exist in this tree)Test plan
python -m pytest tests/ -x -q --ignore=tests/test_integration_full.py-> 2453 passed, 24 skippedGenerated with Gradata