Skip to content

Conversation

@wasamtc
Copy link
Collaborator

@wasamtc wasamtc commented Nov 12, 2025

📋 PR Title Format

The PR title should follow the format:

type(scope): concise message (max 50 chars)

Where:

  • type is one of: feat, fix, docs, refactor, perf, test, chore.
  • scope is optional and describes the part of the codebase affected (e.g., auth, ui, api).
  • concise message is a short description of the change (max 50 chars).

📝 Change Type

Please select the type of change this PR introduces (choose one or more):

  • feat: New feature.
  • fix: Bug fix.
  • docs: Documentation only changes.
  • refactor: A code change that neither fixes a bug nor adds a feature.
  • perf: Performance improvement.
  • test: Adding missing tests or correcting existing tests.
  • chore: Maintenance tasks (e.g., updating dependencies).

💡 Description

The original parameters param-hosting-ratio and kv-cache-ratio have unclear meanings and should be renamed to clearer parameter names.

Key Changes

1.change param-hosting-ration to param_mem_ratio
2.change kv-cache-ratio to kvcache-mem-ratio

🔗 Related Issues

List any issues this PR closes or relates to:

✅ Checklist

Please ensure the following points are addressed before merging:

  • I have performed a self-review of my own code.
  • I have added/updated tests that prove my fix or feature works (if applicable).
  • I have updated the documentation (if necessary).
  • My code follows the project's style guidelines.

@wasamtc wasamtc requested a review from a team November 12, 2025 07:29
@wasamtc wasamtc changed the title fix(bug):param-hosting-ratio -> param_mem_ratio fix(bug): param-hosting-ratio -> param_mem_ratio Nov 12, 2025

kv_cache_ratio: float = 0.3
param_hosting_ratio: float = 0.5
kvcache_mem_ratio: float = 0.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you set default value same as arguments, 0.25 and 0.65

Copy link
Collaborator Author

@wasamtc wasamtc Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you means param_mem_ratio default value is 0.25 and kv_cache_mem_ration is 0.65

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

param_mem_ratio is 0.65 and kv_cache_mem_ration is 0.25

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: The meaning of the parameter param-hosting-ratio is ambiguous.

2 participants