Skip to content

Do not require to be applied after the java/kotlin plugins #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
martinbonnin merged 1 commit into from
Dec 3, 2025
Merged

Do not require to be applied after the java/kotlin plugins #51

martinbonnin merged 1 commit into from
Dec 3, 2025

Conversation

@martinbonnin
Copy link
Member

@martinbonnin martinbonnin commented Dec 3, 2025

Fixes #50

JakeWharton
JakeWharton approved these changes Dec 3, 2025
View reviewed changes
tapmoc-gradle-plugin/src/main/kotlin/tapmoc/internal/TapmocExtensionImpl.kt
Comment on lines +80 to +76
project.plugins.withType(LifecycleBasePlugin::class.java) {
project.tasks.named(LifecycleBasePlugin.CHECK_TASK_NAME).configure {
Copy link
Contributor

@JakeWharton JakeWharton Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@martinbonnin martinbonnin merged commit 0d50abe into main Dec 3, 2025
1 check passed
@martinbonnin martinbonnin deleted the order-independance branch December 3, 2025 20:48
@martinbonnin martinbonnin mentioned this pull request Dec 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JakeWharton JakeWharton JakeWharton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider Java plugin validation failing lazily ,not eagerly

3 participants

@martinbonnin @JakeWharton