nmcpZipAggregation task doesn't create zip when subprojects are up-to-date

[aSemy]

Expected and Results

Given a multi-module project, run ./gradlew nmcpZipAggregation. I see a zip is created in build/nmcp/zip/aggregation.zip.

When I re-run ./gradlew nmcpZipAggregation the output zip is deleted.

It's more risky when some of the subprojects are up-to-date and some aren't. nmcpZipAggregation will create a zip with some of the artifacts missing.

Related environment and versions

nmcp 1.3.0

Reproduction steps

https://github.com/adamko-dev/argh/tree/5052fc4bdb5a367efa7f9d7219783665b793f6e3

Anything else?

No response

[martinbonnin]

Well, that is very unexpected! Thanks for filing this. I can reproduce, will dig more.

[martinbonnin]

I believe this is an interaction with https://github.com/adamko-dev/dev-publish-plugin/blob/6bcb353f65bf4ec51e0b1dfc904ae4f35344bc0e/src/main/kotlin/DevPublishPlugin.kt#L168.

Nmcp operates under the assumption that the publish tasks are never up-to-date because they do not declare an output.

Since DevPublishPlugin is adding outputs to the task, the task becomes incremental. I'm assuming that those outputs are untouched while the build/nmcp/m2 directory is cleared by nmcp to avoid stale outputs (but that directory is not an output so it isn't taken into account when checking for up-to-dateness).

At this point I would say nmcp is working as designed. The publishToNmcpRepository tasks are implementation details and should not be changed by other build logic. I wish there was a way to enforce that in a better way but sadly haven't found any.

[aSemy]

Ohh good spot! Thanks for checking it out.

I agree that nmcp should be able to rely on the publish tasks working as described by Gradle. dev-publish-plugin is misbehaving here.

I'll see if I can update dev-publish-plugin to only modify the publishToDevPublish* publication tasks.

To be very defensive nmcp could add outputs.upToDate { false } to it's own publication tasks? I know it would be going a bit above-and-beyond what would be expected, but if it avoids mispublications I think it could help?

[martinbonnin]

Yup, can do that 👍