nmcpZipAggregation does not create aggregation.zip in one specific case

[malczuuu]

Expected and Results

In a Gradle project with single submodule, where both rootProject.name and included submodule itself have the same name, build/nmcp/zip/aggregation.zip is not created on ./gradlew nmcpZipAggregation task.

The project layout looks like this:

project-name/
├── buildSrc/
│   ├── src/
│   └── build.gradle.kts
├── gradle/
│   ├── wrapper/
│   └── libs.versions.toml
├── project-name/
│   ├── src/
│   └── build.gradle.kts
├── build.gradle.kts
├── gradle.properties
├── gradlew
├── gradlew.bat
└── settings.gradle.kts

I'm aware that with such setup I don't really need that submodule in the first place, and the walkaround was to change rootProject.name to something else, so it's not a big deal.

The project that I've mentioned is here - https://github.com/problem4j/problem4j-core/blob/main/settings.gradle.kts.

Related environment and versions

No response

Reproduction steps

1. Clone my repo - https://github.com/problem4j/problem4j-core.
2. Change rootProject.name to the same name as included submodule in settings.gradle.kts.
3. Run ./gradlew nmcpZipAggregation.
4. Observe that build/libs/nmcp/zip/aggregation.zip is not there.
5. If rootProject.name is changed back to a different than submodule's name, then nmcpZipAggregation would produce build/libs/nmcp/zip/aggregation.zip.

Anything else?

No response

[malczuuu]

While researching a bit more, I've discovered that such setup with rootProject.name being the same as included submodule's name is not recommended in Gradle. I wonder if aggregation.zip missing could be described somewhere in docs (like in https://gradleup.com/nmcp/debugging/ for example)?

[martinbonnin]

I think we need to fail when that happens as other things will go wrong

[malczuuu]

For more info - the publishing task will fail, but just with saying that aggregation.zip is not found. Does not say why aggregation.zip is missing.

> Task :nmcpPublishAggregationToCentralPortal FAILED

FAILURE: Build failed with an exception.

* What went wrong:
A problem was found with the configuration of task ':nmcpPublishAggregationToCentralPortal' (type 'NmcpPublishWithPublisherApiTask').
  - In plugin 'nmcp.NmcpAggregationPlugin_Decorated' type 'nmcp.internal.task.NmcpPublishWithPublisherApiTask' property 'inputFile' specifies file '/home/runner/work/problem4j-core/problem4j-core/build/nmcp/zip/aggregation.zip' which doesn't exist.
    
    Reason: An input file was expected to be present but it doesn't exist.
    
    Possible solutions:
      1. Make sure the file exists before the task is called.
      2. Make sure that the task which produces the file is declared as an input.
    
    For more information, please refer to https://docs.gradle.org/9.2.1/userguide/validation_problems.html#input_file_does_not_exist in the Gradle documentation.

* Try:
> Make sure the file exists before the task is called
> Make sure that the task which produces the file is declared as an input
> Run with --scan to generate a Build Scan (powered by Develocity).

BUILD FAILED in 33s

[martinbonnin]

With #233, this will now be an error.