Skip to content

feat: add deploymentId to the error messages #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinbonnin merged 1 commit into from
May 6, 2025
Merged

feat: add deploymentId to the error messages #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main/kotlin/nmcp/internal/task/publish.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ fun publish(
val mark = markNow()
while (true) {
check (mark.elapsedNow() < timeout) {
"Nmcp: timeout while verifying deployment status."
"Nmcp: timeout while waiting for the deployment $deploymentId to publish. You might need to check the deployment on the Central Portal UI (see $baseUrl$), or you could increase the wait timeout (the current timeout is $timeout)."
}
when (val status = verifyStatus(
deploymentId = deploymentId,
Expand Down Expand Up @@ -149,18 +149,18 @@ private fun verifyStatus(
client.newCall(it).execute()
}.use {
if (!it.isSuccessful) {
error("Cannot verify deployment status (HTTP status='${it.code}'): ${it.body?.string()}")
error("Cannot verify deployment $deploymentId status (HTTP status='${it.code}'): ${it.body?.string()}")
}

val str = it.body!!.string()
val element = Json.parseToJsonElement(str)
check(element is JsonObject) {
"Nmcp: unexpected status response: $str"
"Nmcp: unexpected status response for deployment $deploymentId: $str"
}

val state = element["deploymentState"]
check(state is JsonPrimitive && state.isString) {
"Nmcp: unexpected deploymentState: $state"
"Nmcp: unexpected deploymentState for deployment $deploymentId: $state"
}

return when (state.content) {
Expand All @@ -172,7 +172,7 @@ private fun verifyStatus(
"FAILED" -> {
FAILED(element["errors"].toString())
}
else -> error("Nmcp: unexpected deploymentState: $state")
else -> error("Nmcp: unexpected deploymentState for deployment $deploymentId: $state")
}
}
}
Expand Down