Plugin is not completely compatible with gradle 7.2

[patton73]

Shadow Version

7.0.0

Gradle Version

7.2

After compilation the plugin prints those warning/errors.

Task :shadowJar
Execution optimizations have been disabled for task ':shadowJar' to ensure correctness due to the following reasons:

• Gradle detected a problem with the following location: '...x.jar'. Reason: Task ':distTar' uses this output of task ':shadowJar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.2/userguide/validation_problems.html#implicit_dependency for more details about this problem.
• Gradle detected a problem with the following location: '...x.jar'. Reason: Task ':distZip' uses this output of task ':shadowJar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.2/userguide/validation_problems.html#implicit_dependency for more details about this problem.
• Gradle detected a problem with the following location: '...x.jar'. Reason: Task ':startScripts' uses this output of task ':shadowJar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.2/userguide/validation_problems.html#implicit_dependency for more details about this problem.

Task :startShadowScripts
Execution optimizations have been disabled for task ':startShadowScripts' to ensure correctness due to the following reasons:

• Gradle detected a problem with the following location: '...x.jar'. Reason: Task ':startShadowScripts' uses this output of task ':jar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.2/userguide/validation_problems.html#implicit_dependency for more details about this problem.

Task :shadowDistTar
Execution optimizations have been disabled for task ':shadowDistTar' to ensure correctness due to the following reasons:

• Gradle detected a problem with the following location: '...x.jar. Reason: Task ':shadowDistTar' uses this output of task ':jar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.2/userguide/validation_problems.html#implicit_dependency for more details about this problem.

Task :shadowDistZip
Execution optimizations have been disabled for task ':shadowDistZip' to ensure correctness due to the following reasons:

• Gradle detected a problem with the following location: '...x.jar'. Reason: Task ':shadowDistZip' uses this output of task ':jar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.2/userguide/validation_problems.html#implicit_dependency for more details about this problem.

Is there a way to fix this behaviour?
Thanks in advance.

[jasonculverhouse]

Is there any way to get the code in master released? I think this fixes most of these compatibility issues.

Also, I was unable to get this plugin to work properly if i publish to a local maven repo. Are there any instructions to get that working correctly?

[vyazelenko]

@johnrengelman We are also awaiting a new release to be able to test with JDK 18-ea.

[patton73]

Is this project mantained? I see few commits latest months.

[johnrengelman]

7.1.0 is now out.
sorry for the delays.

[patton73]

Unfortunately this does not resolve the warnings.

[johnrengelman]

@patton73 I don't see any deprecations in any of the automated tests or when I spin up a skeleton project.

$  gradle --version

------------------------------------------------------------
Gradle 7.2
------------------------------------------------------------

Build time:   2021-08-17 09:59:03 UTC
Revision:     a773786b58bb28710e3dc96c4d1a7063628952ad

Kotlin:       1.5.21
Groovy:       3.0.8
Ant:          Apache Ant(TM) version 1.10.9 compiled on September 27 2020
JVM:          1.8.0_121 (Oracle Corporation 25.121-b13)
OS:           Mac OS X 10.16 x86_64

$  gradle assembleShadowDist

BUILD SUCCESSFUL in 3s
5 actionable tasks: 5 executed

[grv87]

IIUC, the problem persisted with all versions of Gradle. It's just that recent versions perform validations more thoroughly.

[patton73]

@johnrengelman These are not deprecations. But A sort of warnings.

Gradle detected a problem with the following location: '...x.jar'. Reason: Task ':distTar' uses this output of task ':shadowJar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.2/userguide/validation_problems.html#implicit_dependency for more details about this problem.

Basically dependencies between internal shadowjar tasks are not declared. And gradle is slow because it does not know with task depends from another.
And to me these warnings anyway seems errors because the order is not clear.

[johnrengelman]

I just don’t see these warnings when I run a project on Gradle 7.2 and shadow 7.1. What am I missing to get them?

[patton73]

@johnrengelman What i have in my build.gradle basically is this:

buildscript {
repositories {
mavenCentral()
}
}

plugins {
id 'com.github.johnrengelman.shadow' version '7.1.0'
}

jar {
manifest.attributes(
'Specification-Version': 'xx',
'Implementation-Version': 'xx'
)
}

shadowJar {
archiveClassifier.set('')
}

I am also using gradle wrapper 7.2
And i get those warnings.

[patton73]

Here it is the project that replicates the error.
Just run "./gradlew build" command.

test-gradle.tar.gz