Skip to content

Use ASM from jdependency embedded #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Goooler merged 1 commit into from
Feb 26, 2026
Merged

Use ASM from jdependency embedded #1927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ publishing.publications.withType<MavenPublication>().configureEach {
dependencies {
api("org.apache.ant:ant:1.10.15") // Types from Ant are exposed in the public API.
implementation("org.jdom:jdom2:2.0.6.1")
implementation("org.ow2.asm:asm-commons:9.9")
implementation("commons-io:commons-io:2.19.0")
implementation("org.codehaus.plexus:plexus-utils:4.0.2")
implementation("org.codehaus.plexus:plexus-xml:4.1.1")
Expand Down
2 changes: 2 additions & 0 deletions src/docs/changes/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
**Fixed**

- Fix resolving BOM dependencies when `minimize` is enabled. ([#1638](https://github.com/GradleUp/shadow/pull/1638))
- Use ASM from jdependency embedded. ([#1898](https://github.com/GradleUp/shadow/pull/1898))
This fixes potential classpath conflicts when using Shadow with other plugins that also use ASM.

## [v8.3.9] (2025-08-05)

Expand Down
2 changes: 1 addition & 1 deletion src/main/groovy/com/github/jengelman/gradle/plugins/shadow/impl/RelocatorRemapper.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import com.github.jengelman.gradle.plugins.shadow.relocation.RelocatePathContext
import com.github.jengelman.gradle.plugins.shadow.relocation.Relocator
import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowCopyAction.RelativeArchivePath
import groovy.transform.CompileStatic
import org.objectweb.asm.commons.Remapper
import org.vafer.jdeb.shaded.objectweb.asm.commons.Remapper

import java.util.regex.Matcher
import java.util.regex.Pattern
Expand Down
8 changes: 4 additions & 4 deletions src/main/groovy/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowCopyAction.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ import org.gradle.api.tasks.WorkResults
import org.gradle.api.tasks.bundling.Zip
import org.gradle.api.tasks.util.PatternSet
import org.gradle.internal.UncheckedException
import org.objectweb.asm.ClassReader
import org.objectweb.asm.ClassVisitor
import org.objectweb.asm.ClassWriter
import org.objectweb.asm.commons.ClassRemapper
import org.vafer.jdeb.shaded.objectweb.asm.ClassReader
import org.vafer.jdeb.shaded.objectweb.asm.ClassVisitor
import org.vafer.jdeb.shaded.objectweb.asm.ClassWriter
import org.vafer.jdeb.shaded.objectweb.asm.commons.ClassRemapper

import java.util.zip.ZipException

Expand Down