Skip to content

Prefer parameterized logging#1977

Merged
Goooler merged 3 commits intomainfrom
copilot/replace-string-templates-logging
Mar 14, 2026
Merged

Prefer parameterized logging#1977
Goooler merged 3 commits intomainfrom
copilot/replace-string-templates-logging

Conversation

Copy link
Contributor

Copilot AI commented Mar 14, 2026

All logger.*() calls that used Kotlin string interpolation ($variable, ${expression}) have been replaced with SLF4J-style {} placeholders. This avoids unnecessary string construction when the log level is disabled.

Before:

logger.info("Relocator count: ${relocators.size}.")
logger.info("Dropping unused class: $className")
logger.info("Adding ${shadowRuntimeElements.name} variant to Java component.")

After:

logger.info("Relocator count: {}.", relocators.size)
logger.info("Dropping unused class: {}", className)
logger.info("Adding {} variant to Java component.", shadowRuntimeElements.name)

Changes span ShadowKmpPlugin.kt, ShadowJar.kt, ShadowJavaPlugin.kt, and ShadowCopyAction.kt.


  • CHANGELOG's "Unreleased" section has been updated, if applicable.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)
  • scans-in.gradle.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
Copilot AI changed the title [WIP] Replace all string templates with {} placeholder styles for logging Replace string templates with {} placeholder styles for logging Mar 14, 2026
Copilot AI requested a review from Goooler March 14, 2026 15:48
@Goooler Goooler marked this pull request as ready for review March 14, 2026 15:48
@Goooler Goooler requested a review from Copilot March 14, 2026 15:49

This comment was marked as outdated.

@Goooler Goooler changed the title Replace string templates with {} placeholder styles for logging Prefer parameterized logging Mar 14, 2026
@Goooler Goooler merged commit cf531d4 into main Mar 14, 2026
6 checks passed
@Goooler Goooler deleted the copilot/replace-string-templates-logging branch March 14, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants