fix: resolve CVE-2026-27142 by updating Go to 1.26.1 (#1182)#1183
fix: resolve CVE-2026-27142 by updating Go to 1.26.1 (#1182)#1183GrammaTonic merged 1 commit intomainfrom
Conversation
This commit updates the Go toolchain version in the `docker/Dockerfile.chrome-go` image from `1.26.0` to `1.26.1`. This resolves the CVE-2026-27142 vulnerability identified by GitHub Code Scanning, which is an XSS vulnerability in the `html/template` package in the Go standard library. Additionally, updates all relevant documentation files (README, CHANGELOG, performance notes, and wiki content) to reflect the new Go version. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: GrammaTonic <8269379+GrammaTonic@users.noreply.github.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a security vulnerability by upgrading the Go toolchain used in the Chrome-Go runner to version 1.26.1. This update ensures the build environment is secure and maintains consistency across all related documentation and configuration files, providing clear and accurate information for users and maintainers. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the Go toolchain from version 1.26.0 to 1.26.1 across the Dockerfile and various documentation files to address a security vulnerability. The changes are consistent and achieve the goal of the PR. I have one suggestion to improve the maintainability of the Dockerfile by defining the Go version as a build argument, consistent with how other tool versions are managed.
| # Go supports both amd64 and arm64 architectures | ||
| RUN --mount=type=cache,target=/tmp/downloads \ | ||
| GO_VERSION="1.26.0" \ | ||
| GO_VERSION="1.26.1" \ |
There was a problem hiding this comment.
For consistency and better maintainability, the Go version should be defined as a build argument (ARG) at the top of the Dockerfile, similar to other versions like NODE_VERSION and CHROME_VERSION. This makes all version definitions easy to find and manage in one place.
Please add ARG GO_VERSION="1.26.1" in the arguments section at the top of the file (around line 37) and remove the hardcoded version from this RUN command.
1 participant
This pull request updates the Go toolchain version used in the Chrome-Go runner from 1.26.0 to 1.26.1. The change is applied consistently across Dockerfiles, documentation, changelogs, and version tables to ensure clarity and accuracy for users and maintainers.
Version update (Go toolchain):
docker/Dockerfile.chrome-gofrom 1.26.0 to 1.26.1, ensuring the Chrome-Go runner uses the latest patch release.Documentation and changelog consistency:
README.md,docs/PERFORMANCE_OPTIMIZATIONS.md,docs/PERFORMANCE_RESULTS.md,docs/releases/CHANGELOG.md, andwiki-content/Home.mdto reflect the updated toolchain version. [1] [2] [3] [4] [5] [6] [7]