Skip to content

QA: pool creation issue for txs with many transfer logs#17

Merged
jmulq merged 1 commit intomasterfrom
bug/pool-creation-event-extraction
Apr 8, 2024
Merged

QA: pool creation issue for txs with many transfer logs#17
jmulq merged 1 commit intomasterfrom
bug/pool-creation-event-extraction

Conversation

@jmulq
Copy link
Copy Markdown
Collaborator

@jmulq jmulq commented Apr 8, 2024

During QA, the subgraph failed at ~91% synced.

This was caused by the following:

  • A deployment event contained may other event logs besides the usual unique transfer event we see relating to a pool from other deployments https://etherscan.io/tx/0xc4f29301d1db7ffaa35f9432f93965f5c5f8fc410503d77f62cadf9f8b51b9aa#eventlog
  • The substream did not have granular enough criteria for extracting the specific transfer event relating to a pool. The prior logic worked for most pool deployment txs, however this edge case above was not handled. The new logic is robust enough to handle all future deployments.

@jmulq jmulq self-assigned this Apr 8, 2024
@jmulq jmulq merged commit 9ead4d2 into master Apr 8, 2024
@jmulq jmulq deleted the bug/pool-creation-event-extraction branch April 8, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant