add dense predefined formats#37
Merged
willow-ahrens merged 3 commits intomainfrom Sep 13, 2023
Merged
Conversation
Automated Review URLs |
willow-ahrens
force-pushed
the
wma/dense-alias
branch
from
c71f9ce to
6959636
Compare
BenBrock
approved these changes
Sep 13, 2023
Contributor
BenBrock
left a comment
BenBrock
left a comment
There was a problem hiding this comment.
This looks good to me!
Personally I like to write values[i + j * number_of_rows] to keep the order consistent but that's a very small nitpick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in the meeting today, here are the predefined formats for dense vectors and matrices