This repository was archived by the owner on Sep 24, 2019. It is now read-only.
Conversation
cjoudrey
reviewed
Feb 8, 2017
| elsif variables.is_a?(String) | ||
| JSON.parse(variables) | ||
| else | ||
| variables |
Contributor
There was a problem hiding this comment.
Should we do anything here? It could be an array, maybe we should Bad Request in that case?
cjoudrey
reviewed
Feb 8, 2017
| @@ -0,0 +1,20 @@ | |||
| class GraphqlController < ApplicationController | |||
| def execute | |||
| query_string = params[:query] | |||
Contributor
There was a problem hiding this comment.
Do we need to .to_s here in case we're passed an array or hash?
cjoudrey
reviewed
Feb 10, 2017
| if variables.blank? | ||
| {} | ||
| elsif variables.is_a?(String) | ||
| JSON.parse(variables) |
Contributor
There was a problem hiding this comment.
Just had a random thought, this could be an array too.
Collaborator
Author
There was a problem hiding this comment.
variables.is_a?(String) no ?
Collaborator
Author
There was a problem hiding this comment.
oh i see what you mean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds graphiql at
/graphiqland a GraphQL controller with an#executeaction at/graphql.Moved types to
models@cjoudrey