Major cleanup #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This automatically propagates the init payload result from the callback into the `onExecute` and `onSubscribe` closures. Since the init callback is usually used to determine authentication and authorization, this should be usable from our execution and subscription calls, and lifecycle is most easily managed within this package
To support receiving messages, we added `listen` functions to server and client. This resolves the confusing ownership rules by avoiding `onReceive` callbacks in Messenger.
Client and Server became actors to ensure sendability, and Messenger was marked sendable
This is not necessary anymore, since you can just map the incoming AsyncStream
NeedleInAJayStack
force-pushed
the
feat/pass-init-result
branch
from
bc395c0 to
8287e17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onInitto downstreamonExecuteandonSubscribe, allowing better handling of auth computationslistenfunctions to listen to incoming async sequences. This detangles the memory management and simplifies the Messenger type.