Verifier changes #131
Merged
Verifier changes #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielDeLayo
approved these changes
Jun 24, 2023
Contributor
DanielDeLayo
left a comment
DanielDeLayo
left a comment
There was a problem hiding this comment.
Reducing the power of the verifier is probably fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verifier is a little overpowered and as a consequence there are a bunch of race conditions if edges are verified by multiple threads. This pull request reduces the power of the verifier while ensuring it still catches bugs. The verifier now checks the following:
The verifiers no longer check that no redundant edges are passed to
verify_edgethis means the verifier has to run a dsu which is a little overpowered and introduces race conditions. We already have tests for the DSU so it's probably fine.