Upgrade markdeep to v1.16 to fix the subheading issue #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arkdeep.min.js is always used
Member
There was a problem hiding this comment.
Can we rename this to markdeep.LICENSE (or something like that) so we know what this license file is for just at a glance?
Contributor
Author
There was a problem hiding this comment.
Sure! But how about moving LICENSE and markdeep.min.js into a folder, I.e. scripts/markdeep?
nickclark2016
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seemed to an issue of subheading index not correctly reset in Markdeep, which is mentioned here (google/filament#3525) and can be observed from the below screenshot.
I upgraded Markdeep to v1.16 (https://github.com/morgan3d/markdeep/releases/tag/v01.16) to fix the issue.
This PR also makes sure that the same JS (markdeep.min.js) is always used across pages.