Skip to content

Reduce flickering #3434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reduce flickering #3434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12b929b
Don't repeatedly open and close the graph
0HyperCube Nov 30, 2025
8dda710
Obey prefers-reduced-motion
0HyperCube Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions frontend/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@
border: 4px solid #eee;
border-color: #eee transparent #eee transparent;
animation: spinning-loading-indicator 1s linear infinite;
@media (prefers-reduced-motion) {
animation: none;
content: "Loading…";
border: none;
}
}

@keyframes spinning-loading-indicator {
Expand Down
8 changes: 8 additions & 0 deletions frontend/src/components/floating-menus/ColorPicker.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,6 +962,10 @@
// We don't use the CSS `filter: grayscale(1);` property because it produces overly dark tones for bright colors with a noticeable jump on hover.
background: var(--pure-color-gray);
transition: background-color 0.1s;

@media (prefers-reduced-motion) {
transition: none;
}
}

&:hover div {
Expand All @@ -976,6 +980,10 @@
&.disabled .details .choice-preview {
transition: opacity 0.1s;

@media (prefers-reduced-motion) {
transition: none;
}

&:hover {
opacity: 0.5;
}
Expand Down
8 changes: 8 additions & 0 deletions frontend/src/components/panels/Document.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,6 +702,10 @@
opacity: 0.25;
transition: opacity 0.1s;

@media (prefers-reduced-motion) {
transition: none;
}

&:hover {
opacity: 1;
}
Expand Down Expand Up @@ -853,6 +857,10 @@
transition: opacity 0.2s;
opacity: 0;

@media (prefers-reduced-motion) {
transition: none;
}

&.open {
cursor: auto;
pointer-events: auto;
Expand Down
4 changes: 4 additions & 0 deletions frontend/src/components/views/Graph.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,10 @@
opacity: 0.5;
transform: translateY(-100%);

@media (prefers-reduced-motion) {
transition: none;
}

// Tail
&::after {
content: "";
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/components/widgets/inputs/NumberInput.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,9 @@
clearTimeout(repeatTimeout);
}

// The widget might be destroyed, in which case it would be very bad to keep sending events pointing at the wrong index.
onDestroy(onIncrementPointerUp);

function incrementPressAbort(e: KeyboardEvent | MouseEvent) {
// Only abort if the user right clicks or presses Escape
if (e instanceof KeyboardEvent && e.key !== "Escape") return;
Expand Down
4 changes: 4 additions & 0 deletions frontend/src/components/widgets/inputs/SpectrumInput.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,10 @@
&.disabled .gradient-strip {
transition: opacity 0.1s;

@media (prefers-reduced-motion) {
transition: none;
}

&:hover {
opacity: 0.5;
}
Expand Down
Loading