Merged
Conversation
TrueDoctor
force-pushed
the
use-glob-for-cargo-toml
branch
from
7bc8127 to
d050429
Compare
timon-schelling
force-pushed
the
master
branch
from
124235a to
a42cad8
Compare
| "editor", | ||
| "frontend/wasm", | ||
| "libraries/dyn-any", | ||
| "libraries/path-bool", |
Member
There was a problem hiding this comment.
Why remove these without adding the glob pattern?
Member
Author
There was a problem hiding this comment.
I think the reason was that all of these are dependencies of other crates, so I don't think it is necessary to have them be part of the default members. This also potentially avoids building these sub dependencies with different feature sets
TrueDoctor
force-pushed
the
use-glob-for-cargo-toml
branch
from
d050429 to
bc10b11
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Keavon
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.