Fix rasterize node document leakage with hashmap and eq check #3550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0HyperCube
reviewed
Dec 31, 2025
Member
|
Alright, I've now pushed another suggestion. If the perf of this is acceptable, I think this is going to be the simplest solution which is hopefully also relatively easy to maintain. @0HyperCube thoughts? |
Contributor
Author
|
This is so much more cleaner , wow |
0HyperCube
approved these changes
Jan 1, 2026
Contributor
0HyperCube
left a comment
0HyperCube
left a comment
There was a problem hiding this comment.
Seems reasonable to me.
Contributor
Author
|
Let me know if there is something which could be done from my side |
Member
|
@Ayush2k02 Could you incorporate hypercubes suggestion and replace the |
Contributor
Author
|
Okay, let me take a look |
Contributor
Author
|
Done ! |
Contributor
Author
Screen.Recording.2026-01-04.at.6.38.51.AM.movSome manual testing |
TrueDoctor
approved these changes
Jan 4, 2026
TrueDoctor
changed the title
Contributor
Author
YAY ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second approach for fixing this bug . Will be tested and benchmarked against #3539 to see if this is better
Closes #3533