Fix opacity not being included in alpha of Fill type when converted from Table<Color>

[Keavon]

Closes #3205.

[gemini-code-assist]

Summary of Changes

Hello @Keavon, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug where the opacity information was lost during the conversion from a Table<Color> to a Fill type. The fix ensures that the alpha value is correctly transferred, maintaining the intended color appearance.

Highlights

• Opacity Fix: Addresses an issue where the opacity (alpha) value was not correctly included when converting a Table<Color> to a Fill type.
• Alpha Blending: Ensures that the alpha value from the Table<Color> is properly applied to the resulting Fill color.
• Issue Resolution: This pull request closes issue Opacity node does not work directly on colors #3205.

Changelog

• node-graph/libraries/vector-types/src/vector/style.rs
  • Fixed opacity not being included in alpha of Fill type when converted from Table

Activity

• Issue Opacity node does not work directly on colors #3205 was closed by this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue where the opacity from a Table<Color> was not being applied to the Fill's alpha channel during conversion. The logic to apply the opacity is correct, but the implementation introduces a potential panic if the input Table<Color> is empty. I've added a review comment with a suggestion to handle this case safely and prevent a crash.

[TrueDoctor]

I would usually prefer to write this with an early return instead of mapping over the option but this should also work