Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
|
||
| mac: | ||
| if: github.event_name == 'push' || inputs.mac | ||
| if: (github.event_name == 'push' && github.ref != 'refs/tags/latest-stable') || inputs.mac |
There was a problem hiding this comment.
why, I would expect it to also build on pushing the tag.
There was a problem hiding this comment.
That build already occurs when we originally push the commit. We haven't yet set up GitHub Releases deployments, but this clause will be removed when we do that.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 issues found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/check.yml">
<violation number="1" location=".github/workflows/check.yml:13">
P2: Routing the PR web build through `build.yml` makes external Cloudflare deploy failures fail CI again.</violation>
<violation number="2" location=".github/workflows/check.yml:16">
P2: This reusable web-build path no longer honors the merge-queue CI skipper.</violation>
</file>
<file name=".github/workflows/build.yml">
<violation number="1" location=".github/workflows/build.yml:223">
P1: Directly interpolating the HTML template output into a quoted `sed` command breaks shell quoting because the template contains double quotes. Store the expression in a shell variable first, then use that variable in `sed`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/check.yml">
<violation number="1" location=".github/workflows/check.yml:22">
P2: Pin this third-party action to an immutable commit SHA instead of the moving `main` branch.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
2 participants
No description provided.