Skip to content

Remove JS module import prefixes and use absolute paths to the frontend directory#3924

Merged
Keavon merged 2 commits intomasterfrom
remove-@graphite-prefix
Mar 21, 2026
Merged

Remove JS module import prefixes and use absolute paths to the frontend directory#3924
Keavon merged 2 commits intomasterfrom
remove-@graphite-prefix

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented Mar 21, 2026

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring of the frontend's module import system. The primary goal is to transition from alias-based and relative imports to a standardized absolute path structure, making the codebase more maintainable and easier to navigate. This change is supported by updated linting rules that enforce the new convention and corresponding adjustments in the build configuration.

Highlights

  • Standardized Import Paths: Refactored all frontend JavaScript module imports to use absolute paths, enhancing consistency and readability across the codebase.
  • ESLint Configuration Update: Updated ESLint rules to enforce the new absolute import path convention and introduced import sorting for better code organization.
  • Build Configuration Alignment: Adjusted tsconfig.json and vite.config.ts to remove old path aliases and align with the new absolute import structure.
  • Asset Path Adjustments: Modified paths for SVG assets and font URLs within Svelte components to conform to the new absolute path system.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 80 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="frontend/eslint.config.js">

<violation number="1" location="frontend/eslint.config.js:70">
P2: The new import restriction misses `../` relative imports, so parent-relative paths are still allowed despite requiring absolute imports.</violation>
</file>

<file name="frontend/src/components/Editor.svelte">

<violation number="1" location="frontend/src/components/Editor.svelte:347">
P2: The new `@font-face` URLs are relative paths (`"src/../node_modules/..."`) and can resolve incorrectly from this component, causing custom fonts to fail loading.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a large-scale refactoring to remove JS module import prefixes and switch to absolute paths from the frontend directory. The changes are extensive, touching almost every file in the frontend to update import paths, and modifying configuration files (eslint.config.js, tsconfig.json, vite.config.ts) to support and enforce this new convention. Overall, the changes are consistent with the goal of the pull request. I've found one issue related to an incorrect path in a CSS url() which likely needs to be corrected.

@github-actions github-actions bot temporarily deployed to graphite-dev (Preview) March 21, 2026 06:49 Inactive
@github-actions github-actions bot temporarily deployed to graphite-dev (Preview) March 21, 2026 07:03 Inactive
@Keavon Keavon merged commit 9bcac1a into master Mar 21, 2026
10 checks passed
@Keavon Keavon deleted the remove-@graphite-prefix branch March 21, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant