Remove JS module import prefixes and use absolute paths to the frontend directory#3924
Remove JS module import prefixes and use absolute paths to the frontend directory#3924
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant refactoring of the frontend's module import system. The primary goal is to transition from alias-based and relative imports to a standardized absolute path structure, making the codebase more maintainable and easier to navigate. This change is supported by updated linting rules that enforce the new convention and corresponding adjustments in the build configuration. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
2 issues found across 80 files
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="frontend/eslint.config.js">
<violation number="1" location="frontend/eslint.config.js:70">
P2: The new import restriction misses `../` relative imports, so parent-relative paths are still allowed despite requiring absolute imports.</violation>
</file>
<file name="frontend/src/components/Editor.svelte">
<violation number="1" location="frontend/src/components/Editor.svelte:347">
P2: The new `@font-face` URLs are relative paths (`"src/../node_modules/..."`) and can resolve incorrectly from this component, causing custom fonts to fail loading.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
Code Review
This pull request is a large-scale refactoring to remove JS module import prefixes and switch to absolute paths from the frontend directory. The changes are extensive, touching almost every file in the frontend to update import paths, and modifying configuration files (eslint.config.js, tsconfig.json, vite.config.ts) to support and enforce this new convention. Overall, the changes are consistent with the goal of the pull request. I've found one issue related to an incorrect path in a CSS url() which likely needs to be corrected.
No description provided.