Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several improvements and bug fixes across the codebase, including handling non-monotonic timestamps in the input mapper, recomputing node click targets when inputs are exposed, and refining scaling logic for degenerate bounding boxes. Additionally, it updates stroke weight defaults and improves the efficiency of arc-length inversion by utilizing the kurbo library. A review comment suggests reintroducing a safety guard for non-finite or zero-length segments in the arc-length calculation to prevent potential numerical instability.
node-graph/libraries/vector-types/src/vector/algorithms/bezpath_algorithms.rs
Show resolved
Hide resolved
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 8 files
Confidence score: 3/5
- There is a concrete rendering regression risk in
node-graph/libraries/rendering/src/render_ext.rs: open paths withaligned_strokesdisabled may omitstroke-width, causing SVG to fall back to width 1 instead of the intended 0.5 behavior. - Given the medium severity (5/10) and fairly strong confidence (7/10), this looks user-visible but scoped to stroke serialization logic rather than a broad system-wide failure.
- Pay close attention to
node-graph/libraries/rendering/src/render_ext.rs- verify open-path stroke defaults are emitted correctly when aligned strokes are disabled.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="node-graph/libraries/rendering/src/render_ext.rs">
<violation number="1" location="node-graph/libraries/rendering/src/render_ext.rs:116">
P2: The new default treats 0.5 as the SVG default for non-centered strokes even when aligned strokes are disabled. For open paths (where `aligned_strokes` is false), this omits `stroke-width` and SVG falls back to 1, rendering thicker strokes than requested (e.g., weight 0.5 becomes 1). Consider only using the 0.5 default when `aligned_strokes` is enabled.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Keavon
force-pushed
the
assorted-bug-fixes
branch
from
4fa3ee2 to
6862e89
Compare
Performance Benchmark Results
|
Keavon
changed the title
1 participant
No description provided.