Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a ResizeObserver to the MenuList component to ensure that virtual scrolling menus only grow and do not shrink while open. The implementation includes logic to track the maximum scroll width and apply it as a min-width to the menu content. Feedback was provided regarding a potential race condition in the asynchronous startMenuWidthObserver function, which could lead to observers being created after a component is closed, and a potential resource leak if existing observers are not disconnected before new ones are initialized.
95fbb87 to
c7ec00e
Compare
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/build.yml">
<violation number="1" location=".github/workflows/build.yml:165">
P2: Preview/manual deployments can be recorded against the wrong ref because `inputs.checkout_ref` is no longer considered when setting `REF`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Fixes #3592