Skip to content

Improve the Data panel's data display with monospaced text and copyable number values#4040

Merged
Keavon merged 3 commits intomasterfrom
data-panel-text-display-improvements
Apr 23, 2026
Merged

Improve the Data panel's data display with monospaced text and copyable number values#4040
Keavon merged 3 commits intomasterfrom
data-panel-text-display-improvements

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented Apr 23, 2026

Broken out from #4010.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several UI and layout improvements, including a new monospace option for text inputs, enhanced tooltips for menu entries, and a truncation utility for breadcrumb labels. It also addresses Safari-specific selection rendering issues and adjusts the data panel to use specialized input widgets. Feedback was provided regarding potential precision loss when displaying 64-bit integers as floats and the use of asynchronous ticks in layout calculations which might cause flickering.

Comment thread frontend/src/components/layout/FloatingMenu.svelte Outdated
…roperties panel, since it makes other floating menus freeze the app
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 10 files

Confidence score: 3/5

  • There is a concrete user-impacting risk in editor/src/messages/portfolio/document/data_panel/data_panel_message_handler.rs: casting u64 to f64 can lose precision for large values, which can silently display incorrect numbers in the UI.
  • The issue in frontend/src/components/widgets/buttons/BreadcrumbTrailButtons.svelte is minor (off-by-one truncation with ellipsis), so it is unlikely to block merge on its own.
  • Given the high-severity, high-confidence precision bug, this carries some regression risk until addressed, even though the second issue is low impact.
  • Pay close attention to editor/src/messages/portfolio/document/data_panel/data_panel_message_handler.rs and frontend/src/components/widgets/buttons/BreadcrumbTrailButtons.svelte - numeric precision in UI rendering and truncation boundary behavior.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="frontend/src/components/widgets/buttons/BreadcrumbTrailButtons.svelte">

<violation number="1" location="frontend/src/components/widgets/buttons/BreadcrumbTrailButtons.svelte:29">
P2: The truncation adds an ellipsis without reserving space for it, causing output to exceed the 40-character limit by one character.</violation>
</file>

<file name="editor/src/messages/portfolio/document/data_panel/data_panel_message_handler.rs">

<violation number="1" location="editor/src/messages/portfolio/document/data_panel/data_panel_message_handler.rs:600">
P1: Casting `u64` to `f64` can silently corrupt large integer values in the UI.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread frontend/src/components/widgets/buttons/BreadcrumbTrailButtons.svelte Outdated
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) April 23, 2026 22:17 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) April 23, 2026 22:22 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) April 23, 2026 22:28 Inactive
@Keavon Keavon merged commit fcf9396 into master Apr 23, 2026
10 checks passed
@Keavon Keavon deleted the data-panel-text-display-improvements branch April 23, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant