Make documents fall back to "Untitled Document" (+ number suffix) if given a blank name#4074
Merged
Conversation
…given a blank name
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors document renaming by moving the logic to the portfolio level and introducing a name resolution system that handles whitespace trimming and automatic 'Untitled' name generation. It also prevents name collisions by allowing the current document to be excluded during name generation. A review comment suggests making the rename operation a no-op if the name remains unchanged to avoid unnecessary resets of the document's save state and file path.
Keavon
added a commit
that referenced
this pull request
Apr 29, 2026
…given a blank name (#4074) * Make documents fall back to "Untitled Document" (+ number suffix) if given a blank name * Bug fix
oluseyi
pushed a commit
to oluseyi/Graphite
that referenced
this pull request
Apr 29, 2026
…given a blank name (GraphiteEditor#4074) * Make documents fall back to "Untitled Document" (+ number suffix) if given a blank name * Bug fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.