Replace the AlphaBlending struct with separate attributes

[Keavon]

No description provided.

[gemini-code-assist]

Code Review

This pull request refactors the alpha blending system by replacing the monolithic AlphaBlending struct with individual attribute columns for blend_mode, opacity, opacity_fill, and clipping_mask. This change improves data granularity and simplifies attribute handling across the codebase. The review identified an inconsistency in the GPU raster rendering logic where opacity_fill_attr was ignored and the layer decision logic differed from the CPU implementation; a suggestion was provided to unify this behavior.

[cubic-dev-ai]

3 issues found across 15 files

Confidence score: 2/5

• There are concrete, user-visible rendering risks: in node-graph/libraries/rendering/src/renderer.rs, artboard clipping is read from the wrong attribute key (severity 7/10, high confidence), so clip settings can be ignored at render time.
• node-graph/libraries/rendering/src/renderer.rs also has a GPU raster mismatch (severity 6/10, high confidence) where opacity handling skips ATTR_OPACITY_FILL and mask-mode composition, which can make output differ from other render paths.
• The issue in node-graph/libraries/core-types/src/table.rs is low risk and documentation-only (comment references ATTR_FILL instead of ATTR_OPACITY_FILL), but it should still be corrected for clarity.
• Pay close attention to node-graph/libraries/rendering/src/renderer.rs - clipping and opacity behavior are both flagged as likely incorrect at runtime.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/libraries/rendering/src/renderer.rs">

<violation number="1" location="node-graph/libraries/rendering/src/renderer.rs:514">
P1: Artboard clipping is read from the wrong attribute key, so artboard clip settings can be ignored at render time.</violation>

<violation number="2" location="node-graph/libraries/rendering/src/renderer.rs:1655">
P2: GPU raster layer opacity ignores `ATTR_OPACITY_FILL` (and mask-mode composition), causing incorrect opacity compared with other render paths.</violation>
</file>

<file name="node-graph/libraries/core-types/src/table.rs">

<violation number="1" location="node-graph/libraries/core-types/src/table.rs:23">
P3: The doc comment references `ATTR_FILL`, but the actual attribute constant is `ATTR_OPACITY_FILL`. Update the comment to the correct name to avoid confusion.

(Based on your team's feedback about consistent, precise terminology in names and docs.) [FEEDBACK_USED]</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}