Skip to content

Fix panel docking bugs and polish its behavior#4087

Merged
Keavon merged 2 commits intomasterfrom
fix-and-polish-panel-docking
May 1, 2026
Merged

Fix panel docking bugs and polish its behavior#4087
Keavon merged 2 commits intomasterfrom
fix-and-polish-panel-docking

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented May 1, 2026

Fixes bugs from #4015. Partly closes #195.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the workspace layout system to use a proportional 0-1 scale for panel sizing and centralizes panel layout state in the frontend portfolio store to prevent data loss during remounts. Feedback points out that some hardcoded panel sizes still use the old 0-100 scale and notes a comment that needs updating to reflect the new normalization target.

Comment thread editor/src/messages/portfolio/utility_types.rs Outdated
Comment thread editor/src/messages/portfolio/utility_types.rs Outdated
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 14 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@Keavon Keavon force-pushed the fix-and-polish-panel-docking branch from 77be482 to 8c8ed9f Compare May 1, 2026 11:15
@Keavon Keavon merged commit 35dcf25 into master May 1, 2026
9 checks passed
@Keavon Keavon deleted the fix-and-polish-panel-docking branch May 1, 2026 11:32
timon-schelling pushed a commit that referenced this pull request May 1, 2026
* Fix panel docking bugs and polish its behavior

* Fix bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rearrange and dock tabs and panel groups in the editor workspace

1 participant