Remove gaps between text glyph bounding box click targets so selection is more reliable#4098
Merged
Remove gaps between text glyph bounding box click targets so selection is more reliable#4098
Conversation
…n is more reliable
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a mechanism to widen glyph bounding boxes horizontally, filling gaps between adjacent characters to improve click-targeting for text. This is achieved by deferring click target creation to the finalize stage and introducing a widen_horizontal_gaps helper function. Review feedback suggests optimizing memory usage by storing bounding boxes directly instead of full subpaths and increasing the floating-point tolerance when comparing baselines to ensure more robust layout calculations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An improvement to #4095.
Each glyph's box is widened to touch the adjacent glyph, instead of just tightly bounding its own geometry: