Skip to content

Fix Pen tool regression that broke dragging a sharp tangent out of the last-placed anchor#4115

Merged
Keavon merged 1 commit into
masterfrom
fix-pen-tool-rubber-band-tangent
May 6, 2026
Merged

Fix Pen tool regression that broke dragging a sharp tangent out of the last-placed anchor#4115
Keavon merged 1 commit into
masterfrom
fix-pen-tool-rubber-band-tangent

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented May 6, 2026

Regression introduced in 123108c.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an early return statement in the PenToolData implementation within pen_tool.rs. This modification prevents the execution of the path-closing logic immediately after the in_segment property of the latest point is cleared. I have no feedback to provide as there were no review comments to evaluate.

@Keavon Keavon merged commit d106bed into master May 6, 2026
10 checks passed
@Keavon Keavon deleted the fix-pen-tool-rubber-band-tangent branch May 6, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant